Convert more character sets with plFontConverter. #1409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zrax
reviewed
Jul 10, 2023
Previously, the user was allowed to manually specify a number of characters to convert. This is a bit of an odd choice and doesn't match what the other (read: non-freetype) methods do (convert everything). We probably don't want all of the glyphs in unicode fonts (for now), but we do want the Latin and Cyrillic ones for sure.
This brings Colin's improvement for the freetype console font rendering over to plFontConverter. The monochrome fonts should no longer be quite so crunchy.
Hoikas
force-pushed
the
font_convert_unicode
branch
from
9e9b6b6 to
f80087e
Compare
zrax
approved these changes
Jul 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, plFontConverter by default converted the first 255 glyphs that it could find. The user could increase or decrease that limit but not have any other control. This PR removes the character counter specification and instead hardwires certain unicode character sets of interest to be converted, namely Latin and Cyrillic (see H-uru/moul-assets#237). Additional character sets are trivial to add by modifying plFontTrueType.cpp. Useful future work might be allowing .p2f files to be compressed, but that currently seems like overkill.
As a bonus, this improves the conversion of monochrome fonts by pulling in @colincornaby's fixes for crunchy freetype monochrome fonts. Further, some
ST::stringgoodness is added.