Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Layer SDL Animation base class editor #79

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

dgelessus
Copy link
Contributor

Related to (but technically not dependent on) H-uru/libhsplasma#281. This does two things:

  • Fixes the "Layer Animation Properties" link in QLayerSDLAnimation to cast to the correct base class (plLayerAnimationBase). Previously, clicking the link crashed PrpShop.
  • Adds a QLayerAnimationBase editor to support the link with the corrected class. This editor is split out of QLayerAnimation, and I've made that link to the new editor as well, instead of having the base class editor "inline". (This matches how PrpShop handles other base class chains like this, e. g. the Win32 sounds.)

Before:

Screenshot before: Layer Animation is one dialog

After:

Screenshot after: Layer Animation is split into two dialogs, and Layer SDL Animation has a working base link

The base class of plLayerSDLAnimation is actually plLayerAnimationBase
and not plLayerAnimation. This was declared inconsistently in
libHSPlasma (see H-uru/libhsplasma#281).
Fixes the "Layer Animation Properties" link in QLayerSDLAnimation now
opening a PRC editor after the previous commit.
@dgelessus dgelessus force-pushed the fix_pllayersdlanimation_base_class branch from ddebf0a to fe42638 Compare March 5, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant