Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expect scaleoffset tests to pass #189

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Expect scaleoffset tests to pass #189

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
87ef44f
Expect scaleoffset tests to pass
mattjala Apr 29, 2024
404aa49
Remove TBD
mattjala Apr 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions test/hl/test_dataset.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -735,10 +735,8 @@ def test_unsupport_dtype(self):
with self.assertRaises(TypeError):
self.f.create_dataset('foo', (20, 30), dtype=bool, scaleoffset=True)

@ut.expectedFailure
def test_float(self):
""" Scaleoffset filter works for floating point data """
# TBD: Add support for scale offset filter

scalefac = 4
shape = (100, 300)
Expand Down Expand Up @@ -767,7 +765,6 @@ def test_float(self):
else:
assert not (readdata == testdata).all()

@ut.expectedFailure
def test_int(self):
""" Scaleoffset filter works for integer data with default precision """

Expand All @@ -789,7 +786,6 @@ def test_int(self):
readdata = self.f['foo'][...]
self.assertArrayEqual(readdata, testdata)

@ut.expectedFailure
def test_int_with_minbits(self):
""" Scaleoffset filter works for integer data with specified precision """

Expand All @@ -810,7 +806,6 @@ def test_int_with_minbits(self):
readdata = self.f['foo'][...]
self.assertArrayEqual(readdata, testdata)

@ut.expectedFailure
def test_int_with_minbits_lossy(self):
""" Scaleoffset filter works for integer data with specified precision """

Expand Down