Add configuration to windows presets #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lrknox
reviewed
Sep 18, 2023
| @@ -299,7 +303,8 @@ | |||
| "inherits": "ci-base", | |||
| "generators": [ | |||
| "ZIP" | |||
| ] | |||
| ], | |||
| "configurations": ["Release"] | |||
There was a problem hiding this comment.
This one is "Configurations", while the others are "Configuration". Is the difference correct?
|
Yes, plural is a list
________________________________________
From: Larry Knox ***@***.***>
Sent: Monday, September 18, 2023 1:37 PM
To: HDFGroup/hdf5-examples
Cc: Allen Byrne; Assign
Subject: Re: [HDFGroup/hdf5-examples] Add configuration to windows presets (PR #31)
@lrknox commented on this pull request.
________________________________
In config/cmake-presets/hidden-presets.json<#31 (comment)>:
@@ -299,7 +303,8 @@
"inherits": "ci-base",
"generators": [
"ZIP"
- ]
+ ],
+ "configurations": ["Release"]
This one is "Configurations", while the others are "Configuration". Is the difference correct?
—
Reply to this email directly, view it on GitHub<#31 (review)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AL77KBUJC3JGHLAZ6Y6A4V3X3CIHBANCNFSM6AAAAAA4YY7FEY>.
You are receiving this because you were assigned.Message ID: ***@***.***>
|
lrknox
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.