Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Update) Override freeleech & doubleup tags when featured #4436

Open
wants to merge 8 commits into
base: 8.x.x
Choose a base branch
from

Conversation

AnabolicsAnonymous
Copy link
Contributor

When featuring torrents the freeleech tag remains unchanged so when filtering through 100% freeleech torrents if that featured torrent didn't have 100% freeleech it will not appear even though it gets freeleech from the feature, same with doubleup. This change commands Meilisearch to include featured torrents in doubleup/freeleech filters.

@AnabolicsAnonymous AnabolicsAnonymous changed the title update: override freeleech and doubleup tags when featured update: override freeleech & doubleup tags when featured Jan 19, 2025
Copy link
Collaborator

@Roardom Roardom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the logic is changed for the meilisearch search filters, then it should probably be changed for the sql logic as well at the top of this file.

app/DTO/TorrentSearchFiltersDTO.php Outdated Show resolved Hide resolved
app/DTO/TorrentSearchFiltersDTO.php Outdated Show resolved Hide resolved
AnabolicsAnonymous and others added 2 commits January 18, 2025 23:42
Co-authored-by: Roardom <[email protected]>
Co-authored-by: Roardom <[email protected]>
Copy link
Collaborator

@Roardom Roardom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure if you still planned to do it, but the sql logic at the top of the file has to match the logic you changed here.

@AnabolicsAnonymous
Copy link
Contributor Author

Not sure if you still planned to do it, but the sql logic at the top of the file has to match the logic you changed here.

I did it was just late yesterday, I can't really tell where the sql changes take place so I have no real way of knowing if the logic I added is correct so I need you to check that, also made a change so it only includes the featured torrents if 100% freeleech is ticked.

app/DTO/TorrentSearchFiltersDTO.php Outdated Show resolved Hide resolved
app/DTO/TorrentSearchFiltersDTO.php Outdated Show resolved Hide resolved
app/DTO/TorrentSearchFiltersDTO.php Outdated Show resolved Hide resolved
@HDVinnie HDVinnie changed the title update: override freeleech & doubleup tags when featured (Update) Override freeleech & doubleup tags when featured Jan 22, 2025
@HDVinnie
Copy link
Collaborator

LGTM thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants