Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use correct antpairs when finding bad pairs #53

Merged
merged 1 commit into from
Aug 26, 2024

Conversation

steven-murray
Copy link
Contributor

This fixes a couple of things related to using nonavg data:

  • it fixes the autocorrelation plot, and makes it a little faster (it was trying to plot many many panels previously)
  • it fixes an error where the full list of antpairs was being used instead of just the ones for this chunk
  • it tries to improve the memory consumption in the very last plot by closing figures after showing them.

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@steven-murray steven-murray requested a review from jsdillon August 23, 2024 15:00
Copy link
Member

@jsdillon jsdillon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks ok to me. Since it's just plotting code, I'm not really sure if it needs peer-review, but let me know if you want me to look more closely at any particular part.

@steven-murray steven-murray merged commit 23b91a2 into master Aug 26, 2024
0 of 4 checks passed
@steven-murray steven-murray deleted the fix-nonavg-lststack branch August 26, 2024 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants