Update for uvdata3 #453
Merged
Update for uvdata3 #453
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #453 +/- ##
==========================================
- Coverage 97.09% 97.06% -0.03%
==========================================
Files 11 11
Lines 3544 3549 +5
==========================================
+ Hits 3441 3445 +4
- Misses 103 104 +1 ☔ View full report in Codecov by Sentry. |
|
@bhazelton note that the missing coverage line will not be missing for pyuvdata 3. It's impossible to cover for pyuvdata 2. |
bhazelton
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates code to work for pyuvdata v3+. Mostly this means assuming that the results from
_key2indsandantpair2indsare possibly slices, rather than arrays of integers. It also fixes a problem with usingpytest.warns(None)which is deprecated in pytest 8, and replaces it withpyuvdata.tests.check_warnings(), which is much simpler anyway.