Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimal ruff #457

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Minimal ruff #457

merged 4 commits into from
Feb 20, 2024

Conversation

steven-murray
Copy link
Contributor

@steven-murray steven-murray commented Feb 16, 2024

Here I used adopt-ruff (https://github.com/ScDor/adopt-ruff) to find all the linting fixes that:

  1. We're already obeying
  2. Can be automatically fixed by ruff
  3. We weren't already obeying and aren't auto-fixable but seemed easy enough to fix manually AND important to fix now (e.g. numpy deprecations for numpy v2)

I have not run ruff format (so no "black" style formatting) and I also ignored line-too-long errors. No functionality should be changed.

I am ignoring one file (test_xrfi_performance) which has A LOT of violations, including many "variable name not defined" which makes me think it's completely out of date and should be deleted.

There's one error that I didn't fix because I wasn't sure how to fix it (but it's definitely an error) -- an undefined variable name i.

@jsdillon
Copy link
Member

Looks like we're failing all our tests, @steven-murray mostly related to np.random issues?

Copy link

codecov bot commented Feb 19, 2024

Codecov Report

Attention: 4 lines in your changes are missing coverage. Please review.

Comparison is base (90eb2c0) 97.07% compared to head (d2e4daa) 97.10%.

Files Patch % Lines
hera_qm/metrics_io.py 90.62% 3 Missing ⚠️
hera_qm/vis_metrics.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #457      +/-   ##
==========================================
+ Coverage   97.07%   97.10%   +0.03%     
==========================================
  Files          11       11              
  Lines        3553     3527      -26     
==========================================
- Hits         3449     3425      -24     
+ Misses        104      102       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jsdillon jsdillon merged commit 08f42c8 into main Feb 20, 2024
10 of 11 checks passed
@jsdillon jsdillon deleted the minimal-ruff branch February 20, 2024 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants