Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for posting a join request #742

Merged
merged 2 commits into from
Mar 5, 2022
Merged

Add test for posting a join request #742

merged 2 commits into from
Mar 5, 2022

Conversation

hazemessam
Copy link
Contributor

@hazemessam hazemessam commented Mar 5, 2022

Issue that this pull request solves

Ref issue - # 710

Brief description of what is fixed or changed

  • Removed 2 duplicated fields [domain, department] from join us validation schema
  • Added test for POST /joinus

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

Screenshots

image

@auto-assign auto-assign bot requested a review from jackfrost13 March 5, 2022 09:11
@hazemessam
Copy link
Contributor Author

@Kajol-Kumari Is still any problem with this PR?

@hazemessam hazemessam requested a review from Kajol-Kumari March 5, 2022 09:44
@Kajol-Kumari Kajol-Kumari removed the request for review from jackfrost13 March 5, 2022 13:08
Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Kajol-Kumari Kajol-Kumari added GSSoC22 Identifier for GirlScript Summer of Code sprint level1 Wiki or Major Documentation work. labels Mar 5, 2022
@Kajol-Kumari Kajol-Kumari merged commit d6829c9 into HITK-TECH-Community:main Mar 5, 2022
@hazemessam hazemessam changed the title Test post join us api Test post join us API Mar 6, 2022
@hazemessam hazemessam changed the title Test post join us API Tested post join us api Mar 7, 2022
@hazemessam hazemessam changed the title Tested post join us api Test post join us request Mar 7, 2022
@hazemessam hazemessam changed the title Test post join us request Add test for posting a join us request Mar 7, 2022
@hazemessam hazemessam changed the title Add test for posting a join us request Add test for posting a join request Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
GSSoC22 Identifier for GirlScript Summer of Code sprint level1 Wiki or Major Documentation work.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants