-
Notifications
You must be signed in to change notification settings - Fork 318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Backend] Problem in delete contact us api Fixed #933
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,55 +1,26 @@ | ||
const to = require('await-to-js').default; | ||
const { ErrorHandler } = require('../../../helpers/error'); | ||
const constants = require('../../../constants'); | ||
const Contact = require("../../models/contactUs"); | ||
const Admin = require("../../models/Admin"); | ||
const mongoose = require('mongoose'); | ||
const ContactUs = require('../../models/contactUs'); | ||
|
||
// Controller to delete a contact by adminid and contactdocumentid | ||
module.exports = async (req, res, next) => { | ||
const { contactId, adminId } = req.body; | ||
try { | ||
const payload = res.locals.decode; | ||
const { contactUsId } = req.body; | ||
|
||
// Check if contactId is provided | ||
if (!contactId || !adminId) { | ||
const error = new ErrorHandler(constants.ERRORS.VALIDATION, { | ||
statusCode: 400, | ||
message: 'Validation Error', | ||
errStack: 'Both IDs are required to delete a contact', | ||
}); | ||
return next(error); | ||
if (!payload.isSuperAdmin) { | ||
return res.status(401).json({ error: 'You are not authorized to perform this action' }); | ||
} | ||
//Find if the user is admin or not | ||
const admin = await to(Admin.findOne({ _id: adminId })); | ||
if (!admin) { | ||
const error = new ErrorHandler(constants.ERRORS.USER, { | ||
statusCode: 400, | ||
message: "Admin Validation Error", | ||
errStack: "Admin user provided not found in database" | ||
}) | ||
return next(error); | ||
} | ||
// Delete the contact | ||
const [err, result] = await to(Contact.findByIdAndDelete(contactId)); | ||
|
||
if (err) { | ||
const error = new ErrorHandler(constants.ERRORS.DATABASE, { | ||
statusCode: 500, | ||
message: 'Database Error', | ||
errStack: err, | ||
}); | ||
return next(error); | ||
if (!mongoose.Types.ObjectId.isValid(contactUsId)) { | ||
return res.status(400).json({ error: 'Invalid Contact Us ID' }); | ||
} | ||
|
||
if (!result) { | ||
const error = new ErrorHandler(constants.ERRORS.NOT_FOUND, { | ||
statusCode: 404, | ||
message: 'Contact Not Found', | ||
}); | ||
return next(error); | ||
const contactUsEntry = await ContactUs.findByIdAndDelete(contactUsId); | ||
if (!contactUsEntry) { | ||
return res.status(404).json({ error: 'Contact Us entry not found' }); | ||
} | ||
|
||
res.status(200).send({ | ||
message: 'Contact deleted successfully', | ||
}); | ||
|
||
return next(); | ||
}; | ||
return res.status(200).json({ message: 'Contact Us entry deleted successfully' }); | ||
} catch (error) { | ||
return res.status(500).json({ error: 'Internal server error' }); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[ques] why are we doing this check? shouldn't auth middleware take care of it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kajol-Kumari It is the code flow. I followed based on existing code bases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kajol-Kumari in every file they is this type of check. So I thought Auth Middleware doesn't handle it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can u provide me the reference of where do u see it, it shouldn't be required ideally, try removing and then test the delete functionality, it should not work without authorization key of an admin
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Kajol-Kumari can you please check this here i saw like this Here