Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Frontend] Integrated the Get Team API With Frontend Fixed #972

Merged
merged 3 commits into from
May 27, 2024

Conversation

Hemu21
Copy link
Contributor

@Hemu21 Hemu21 commented May 26, 2024

Issue that this pull request solves

Issue Link resolve #724
Closes: #724

Brief description of what is fixed or changed

The founder &Co-founder details is hardcoded and Rest all the cards are populated a/c the data fetched from backend. Checked user to redirect to respective social media account profile page. made default profile if image is not uploaded.

Types of changes

Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update (Documentation content changed)
  • Other (please describe):

Checklist

Put an x in the boxes that apply

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • My changes does not break the current system and it passes all the current test cases.

@auto-assign auto-assign bot requested a review from Kajol-Kumari May 26, 2024 13:33
@Hemu21
Copy link
Contributor Author

Hemu21 commented May 26, 2024

@Kajol-Kumari If you got free time can you please check and merge it.

Copy link
Member

@Kajol-Kumari Kajol-Kumari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in founder and co-founder section can u keep a single card and add my info there, it should be hardcoded as it won't ever change, you take all the info from https://github.com/Kajol-Kumari

frontend/src/pages/About/About.jsx Show resolved Hide resolved
frontend/src/pages/About/About.jsx Outdated Show resolved Hide resolved
@Hemu21
Copy link
Contributor Author

Hemu21 commented May 26, 2024

@Kajol-Kumari Ok I will update

@Hemu21
Copy link
Contributor Author

Hemu21 commented May 27, 2024

@Kajol-Kumari I had updated it can you please check it.

@Kajol-Kumari Kajol-Kumari added level3 New features, major bug fixing. gssoc GSSoC'24 Label labels May 27, 2024
@Kajol-Kumari Kajol-Kumari merged commit 17746ad into HITK-TECH-Community:main May 27, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
gssoc GSSoC'24 Label level3 New features, major bug fixing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Frontend] Integrated the Get Team API With Frontend
2 participants