Add social media icons #329
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 7f7f8ff.
|
I'm confused on why backend is failing. I haven't touched it. |
|
After ten years 🙏🙏🙏 |
kyle1373
reviewed
Oct 23, 2022
| flexDirection: 'column-reverse', | ||
| height: '100%', | ||
| borderCollapse: 'collapse', | ||
| paddingLeft: '2px', |
There was a problem hiding this comment.
I would make paddingLeft with the value 0px. This would center the buttons instead of having them slightly more aligned to the right than normal
kyle1373
reviewed
Oct 23, 2022
| @@ -33,6 +33,33 @@ const styles = theme => ({ | |||
| h5: { | |||
| marginBottom: theme.spacing(2), | |||
| }, | |||
| container: { | |||
There was a problem hiding this comment.
This shouldn't have the name container as it seems too general. Maybe a better name would be socialContainer.
kyle1373
requested changes
Oct 23, 2022
kyle1373
previously approved these changes
Nov 3, 2022
Adneths
previously approved these changes
Nov 13, 2022
| } | ||
|
|
||
|
|
||
| export const SocialButtons = [ |
There was a problem hiding this comment.
Since it's not actually exporting a Button element, it may be clearer to rename it to Info or Link instead of button, same for other instances and file name.
laurenkiyomi
previously approved these changes
Nov 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.