[Do not merge] DT-5921 Fix transfer cache requests #416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The car transfer requests should generate walk transfer requests because these requests use OTPs QualifiedModeSet and currently it is configured this way. This will be changed by me in a future pr to OTP. |
VillePihlava
changed the title
VillePihlava
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the
BICYCLE_RENTtransfer cache requests that were not used. They are replaced withBICYCLEtransfer cache requests that have additional fields. The added fields are non-required information in theory, but are required by the current OTP implementation.This PR also adds
CARtransfer cache requests in the finland and waltti configs. These will be properly utilized once the features from this PR are used: opentripplanner/OpenTripPlanner#5966.