Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance Build Process #428

Open
wants to merge 20 commits into
base: v3
Choose a base branch
from
Open

Enhance Build Process #428

wants to merge 20 commits into from

Conversation

laardee
Copy link

@laardee laardee commented Dec 19, 2024

This PR introduces some improvements and optimizations:

  • Splits Gulp runtime configurations into router-specific files for better modularity.
  • Updates Dockerfiles, light-http configs, and scripts to use parameters, avoiding unnecessary changes to git-tracked files.
  • Improves the clarity of error messages in specific scenarios.
  • Adds support for environment variables to skip selected build steps, reducing development time.
  • Skips pushing images to the Docker registry if credentials are not defined, ensuring the build process in unconfigured environments, like development.

Partly related to the old issue #189

Copy link
Member

@vesameskanen vesameskanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution. Using variables instead of modifying local version managed files is a good improvement.

Some notes, though:

  • Unused task/PatchDeploymentFiles.js should be deleted, the reference to it in gulpfile removed and README.md updated to reflect the changes.

  • Build process works but creates a broken OTP image. When running the image, kubernetes deployment shows an error:

    Reason: CrashLoopBackOff
    Last State: Terminated
    Reason: StartError
    Message: failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "/var/otp/entrypoint.sh": stat /var/otp/entrypoint.sh: no such file or directory: unknown

This error is a bit strange as I can find /var/otp/entrypoint.sh from the docker image. Any ideas?

Comment on lines +10 to +11
const mapSrc = (id, url, fit, rules, replacements, request) => ({ id, url, fit, rules, replacements, request })

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it be more natural to import this one liner from util.js ? task folder contains gulp tasks and the main update logic.

@vesameskanen
Copy link
Member

Found out that our container deployment mounts data storage to path /var/otp . I assume that this mounting overwrites the original folder where the entrypoint script is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants