-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhance Build Process #428
base: v3
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the contribution. Using variables instead of modifying local version managed files is a good improvement.
Some notes, though:
-
Unused task/PatchDeploymentFiles.js should be deleted, the reference to it in gulpfile removed and README.md updated to reflect the changes.
-
Build process works but creates a broken OTP image. When running the image, kubernetes deployment shows an error:
Reason: CrashLoopBackOff
Last State: Terminated
Reason: StartError
Message: failed to create containerd task: failed to create shim task: OCI runtime create failed: runc create failed: unable to start container process: exec: "/var/otp/entrypoint.sh": stat /var/otp/entrypoint.sh: no such file or directory: unknown
This error is a bit strange as I can find /var/otp/entrypoint.sh from the docker image. Any ideas?
const mapSrc = (id, url, fit, rules, replacements, request) => ({ id, url, fit, rules, replacements, request }) | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be more natural to import this one liner from util.js ? task folder contains gulp tasks and the main update logic.
Found out that our container deployment mounts data storage to path |
This PR introduces some improvements and optimizations:
Partly related to the old issue #189