Merge pull request #2882 from HSLdevcom/no-console

Throw eslint error from using console commands

.eslintrc.js

@@ -12,7 +12,7 @@ module.exports = {
     'lines-between-class-members': 'warn',
     'no-else-return': 'warn',
     'no-plusplus': ['error', { "allowForLoopAfterthoughts": true }],
-
+    'no-console': 'error',
     // react
     'react/button-has-type': 'warn',
     'react/destructuring-assignment': 'warn',

app/action/PositionActions.js

@@ -142,7 +142,7 @@ function watchPosition(actionContext) {
     }
     actionContext.dispatch('GeolocationNotSupported');
     updateGeolocationMessage(actionContext, 'failed');
-    console.error(error);
+    console.error(error); // eslint-disable-line no-console
   }
 }
 

app/component/AdminPage.js

@@ -40,7 +40,7 @@ class AdminPage extends React.Component {
           });
         },
         err => {
-          console.log(err);
+          console.log(err); // eslint-disable-line no-console
           this.setState({ loading: false });
         },
       );

app/component/MessageBar.js

@@ -214,9 +214,8 @@ class MessageBar extends Component {
       ) {
         return true;
       }
-      /* eslint-disable no-console */
+      // eslint-disable-next-line no-console
       console.error(`Message ${el.id} has no translation for ${lang}`);
-      /* eslint-enable no-console */
       return false;
     });
   };

app/component/TripLink.js

@@ -27,7 +27,7 @@ function TripLink(props) {
       </Link>
     );
   }
-
+  // eslint-disable-next-line no-console
   console.warn('Unable to match trip', props);
   return <span className="route-now-content">{icon}</span>;
 }

app/component/map/popups/TicketSalesPopup.js

@@ -19,6 +19,7 @@ export function getIcon(type) {
     case 'R-kioski':
       return 'icon-icon_ticket-sales-point';
     default:
+      // eslint-disable-next-line no-console
       console.log(`Unknown ticket sales type: ${type}`);
       return 'icon-icon_ticket-sales-point';
   }

app/component/map/tile-layer/CityBikes.js

@@ -67,7 +67,7 @@ class CityBikes {
 
           this.features.forEach(actionFn);
         },
-        err => console.log(err),
+        err => console.log(err), // eslint-disable-line no-console
       );
     });
 

app/component/map/tile-layer/ParkAndRide.js

@@ -124,7 +124,7 @@ export default class ParkAndRide {
             }
           }
         },
-        err => console.log(err),
+        err => console.log(err), // eslint-disable-line no-console
       );
     });
   }

app/component/map/tile-layer/Stops.js

@@ -185,7 +185,7 @@ class Stops {
             }
           }
         },
-        err => console.log(err),
+        err => console.log(err), // eslint-disable-line no-console
       );
     });
   }

app/component/map/tile-layer/TicketSales.js

@@ -79,7 +79,7 @@ export default class TicketSales {
             }
           }
         },
-        err => console.log(err),
+        err => console.log(err), // eslint-disable-line no-console
       );
     });
   }

app/localStorageHistory.js

@@ -55,6 +55,7 @@ const getLocationListener = () => event => {
       PUSH(event);
       break;
     default:
+      // eslint-disable-next-line no-console
       console.error('unhandled history event:', event);
   }
   if (this && this[event.action] !== undefined) {

app/server.js

@@ -379,6 +379,7 @@ export default function(req, res, next) {
         return [content, relayData];
       })
       .catch(err => {
+        // eslint-disable-next-line no-console
         console.log(err);
         return ['', undefined];
       });

app/store/localStorage.js

@@ -34,6 +34,7 @@ function setItem(key, value) {
       localStorage.setItem(key, JSON.stringify(value));
     } catch (error) {
       if (error.name === 'QuotaExceededError') {
+        // eslint-disable-next-line no-console
         console.log(
           '[localStorage]' + // eslint-disable-line no-console
             ' Unable to save state; localStorage is not available in Safari private mode',

app/store/sessionStorage.js

@@ -33,6 +33,7 @@ function setItem(key, value) {
       sessionStorage.setItem(key, JSON.stringify(value));
     } catch (error) {
       if (error.name === 'QuotaExceededError') {
+        // eslint-disable-next-line no-console
         console.log(
           '[sessionStorage]' + // eslint-disable-line no-console
             ' Unable to save state; sessionStorage is not available in Safari private mode',

build/generate-schema.js

@@ -1,4 +1,4 @@
-/* eslint-disable import/no-extraneous-dependencies */
+/* eslint-disable import/no-extraneous-dependencies, no-console */
 
 const fs = require('fs');
 const { introspectionQuery } = require('graphql/utilities/introspectionQuery');

server/proxyTester.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 const express = require('express');
 const proxy = require('express-http-proxy');
 

test/flow/custom_commands/debug.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 exports.command = function debug(...args) {
   try {
     this.perform(() => {

test/unit/helpers/init.js

@@ -1,3 +1,4 @@
+/* eslint-disable no-console */
 import { expect } from 'chai';
 import { configure } from 'enzyme';
 import Adapter from 'enzyme-adapter-react-16';

test/visual/components.js

@@ -1,5 +1,5 @@
 /* global gemini */
-
+/* eslint-disable no-console */
 /**
  * Customizable test function
  * @componentName the component name to test