Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Many updates to dependencies and improved github workflows #4838

Merged
merged 64 commits into from
Aug 21, 2023
Merged

Many updates to dependencies and improved github workflows #4838

merged 64 commits into from
Aug 21, 2023

Commits on Jun 23, 2023

  1. CI: merge v3-dev into dev pipeline

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    9b55602 View commit details
    Browse the repository at this point in the history

  2. CI: use env var & $GITHUB_OUTPUT instead of set-output 

    set-output has been deprecated: https://github.blog/changelog/2022-10-11-github-actions-deprecating-save-state-and-set-output-commands/
    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    65a990e View commit details
    Browse the repository at this point in the history

  3. Yarn: run Node v14 patch after each install

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    6e45b0d View commit details
    Browse the repository at this point in the history

  4. Dockerfile: minor tweaks 

    - use 1.4 syntax to support `COPY --link` commands
- set NODE_ENV=production
- remove $WORK build arg
    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    354a00e View commit details
    Browse the repository at this point in the history

  5. Dockerfile: use multi-stage build for yarn install

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    a9c5d5d View commit details
    Browse the repository at this point in the history

  6. Dockerfile: yarn install: run with --immutable

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    db4ea7a View commit details
    Browse the repository at this point in the history

  7. Dockerfile: yarn install: skip Playwright browser download

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    dc959d0 View commit details
    Browse the repository at this point in the history

  8. Dockerfile: yarn install: tweak CLI output

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    3f5eda9 View commit details
    Browse the repository at this point in the history

  9. Dockerfile: node:12 -> node:14-alpine, CI dev pipeline: use Node v14

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    6248afa View commit details
    Browse the repository at this point in the history

  10. Dockerfile: yarn build: tweak removal of caches & artifacts, tweak ca… 

    …ching

- If e.g. `test` has been added in a command/step, removing it in a
subsequent command/step does not have a positive effect on the image size.
Rather, we add it .dockerignore to stop adding it in the first place.
- node_modules/.cache & /tmp/Relay* are populated by Webpack plugins.
    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    a035ed7 View commit details
    Browse the repository at this point in the history

  11. fix Docker build: favicons-webpack-plugin@^3 & update webpack@^4

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    38ef053 View commit details
    Browse the repository at this point in the history

  12. make source map generation configurable

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    1435ca8 View commit details
    Browse the repository at this point in the history

  13. .dockerignore: ignore .github, keep README & co, remove obsolete paths

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    f230587 View commit details
    Browse the repository at this point in the history

  14. Webpack stats.json: only include .entrypoints 

    app/server.js reads .entrypoints.main.assets in order to generate an appropriate
manifest and `preload` tags, but it doesn't need the rest. This is why we turn
all stats off via `all: false` and then selectively turn `entrypoints` on.

Before, stats.json was 82mb, now it is ~9kb.
    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    76df655 View commit details
    Browse the repository at this point in the history

  15. Dockerfile: add labels following OCI image spec

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    49ae0ff View commit details
    Browse the repository at this point in the history

  16. CI dev pipeline: cache .yarn/cache in addition to node_modules 

    Even if a commit has changed `yarn.lock`, we can use an old `.yarn/cache` directory, so that we don't have to fetch 99% of all dependencies again.
    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    f01c604 View commit details
    Browse the repository at this point in the history

  17. CI dev pipeline: re-install node_modules only if not cached

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    8c11bb5 View commit details
    Browse the repository at this point in the history

  18. CI dev pipeline: rebuild shared components only if not cached

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    1af94b5 View commit details
    Browse the repository at this point in the history

  19. CI dev pipeline: rebuild Relay queries only if not cached

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    b3d3e62 View commit details
    Browse the repository at this point in the history

  20. CI dev pipeline: don't let Playwright download unused browsers

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    1674733 View commit details
    Browse the repository at this point in the history

  21. CI dev pipeline: minor tweaks

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    f916cfc View commit details
    Browse the repository at this point in the history

  22. CI dev/hotfix pipelines: build & publish Docker img via buildx & GH a… 

    …ction
    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    b00472a View commit details
    Browse the repository at this point in the history

  23. CI dev/hotfix pipelines: cache Docker layers via GitHub cache

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    cb5c45c View commit details
    Browse the repository at this point in the history

  24. CI dev/hotfix pipeline: re-enable linting of SVG icons 

    This reverts 32bbfa8, which reverts 3f6e105, which apparently failed because of an unrelated problem[1].

[1] https://github.com/HSLdevcom/digitransit-ui/actions/runs/4762670497/jobs/8469259999
    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    dc76ec4 View commit details
    Browse the repository at this point in the history

  25. jyvaskyla config.logo: use relative path 

    This probably improves favicons-webpack-plugin's performance, as node_modules won't be resolved for resolving the path.
    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    8dae91b View commit details
    Browse the repository at this point in the history

  26. Dockerfile: add health check

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    b88f101 View commit details
    Browse the repository at this point in the history

  27. Dockerfile: allow passing in $CONFIG as build arg

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    a3eae2a View commit details
    Browse the repository at this point in the history

  28. don't build startup images for iOS/iPadOS 

    This speeds up the webpack build within the Docker image build significantly.
    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    9904c4c View commit details
    Browse the repository at this point in the history

  29. debug CI [drop]

    @derhuerst
    derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    abfbfd8 View commit details
    Browse the repository at this point in the history

  30. chore: upgrade to Node.js v16; css-loader@5, sass-loader@10, node-sass@6 

    Co-Authored-By: Jannis R <[email protected]>
    @hbruch @derhuerst
    hbruch and derhuerst committed Jun 23, 2023
    Configuration menu
    Copy the full SHA
    3dfe228 View commit details
    Browse the repository at this point in the history

Commits on Jun 24, 2023

  1. chore: remove truly broken or disabled tests

    @vesameskanen @derhuerst
    vesameskanen authored and derhuerst committed Jun 24, 2023
    Configuration menu
    Copy the full SHA
    d2cd3b0 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2023

  1. chore: update more dev deps, replace deprecated codecov library with … 

    …github actions

cherry-pick of b8333bd
    @vesameskanen @derhuerst
    vesameskanen authored and derhuerst committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    704349c View commit details
    Browse the repository at this point in the history

  2. debug CI [drop]

    @derhuerst
    derhuerst committed Jun 26, 2023
    Configuration menu
    Copy the full SHA
    20bbed6 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2023

  1. Merge branch 'improve-ci-speed' into v3

    @vesameskanen
    vesameskanen committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    031fe85 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'node16-upstream' into v3

    @vesameskanen
    vesameskanen committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    b1ce938 View commit details
    Browse the repository at this point in the history

  3. chore: update lockfile

    @vesameskanen
    vesameskanen committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    8e89317 View commit details
    Browse the repository at this point in the history

  4. chore: merge tested branches

    @vesameskanen
    vesameskanen committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    eab9da4 View commit details
    Browse the repository at this point in the history

  5. chore: update some dev deps

    @vesameskanen
    vesameskanen committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    32c4068 View commit details
    Browse the repository at this point in the history

  6. chore: build node-migration image

    @vesameskanen
    vesameskanen committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    ba2ad30 View commit details
    Browse the repository at this point in the history

  7. chore: axe does not work with node16, comment out the code

    @vesameskanen
    vesameskanen committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    792d31e View commit details
    Browse the repository at this point in the history

  8. chore: fix metadata, favicon and other app imagery generation at prod… 

    …uction build
    @vesameskanen
    vesameskanen committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    70a45c5 View commit details
    Browse the repository at this point in the history

  9. chore: remove tab from yaml

    @vesameskanen
    vesameskanen committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    1a027c8 View commit details
    Browse the repository at this point in the history

  10. fix: do not expect yarn build to be run when setting up configuration

    @vesameskanen
    vesameskanen committed Jul 7, 2023
    Configuration menu
    Copy the full SHA
    1d8a8e8 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2023

  1. chore: prepare workflow to work after merging it to v3

    @vesameskanen
    vesameskanen committed Jul 8, 2023
    Configuration menu
    Copy the full SHA
    6e50e2e View commit details
    Browse the repository at this point in the history

Commits on Aug 14, 2023

  1. Merge branch 'v3' into node-migration

    @vesameskanen
    vesameskanen committed Aug 14, 2023
    Configuration menu
    Copy the full SHA
    efb2a30 View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2023

  1. chore: update dev-pipeline, add npm publish task back

    @vesameskanen
    vesameskanen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f7dc552 View commit details
    Browse the repository at this point in the history

  2. chore: try removing shell

    @vesameskanen
    vesameskanen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    133dbdd View commit details
    Browse the repository at this point in the history

  3. chore: fix indentation

    @vesameskanen
    vesameskanen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    39a980f View commit details
    Browse the repository at this point in the history

  4. chore: tune dev workflow

    @vesameskanen
    vesameskanen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f94548e View commit details
    Browse the repository at this point in the history

  5. fix: handle multi line envs correctly

    @vesameskanen
    vesameskanen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    f331b7c View commit details
    Browse the repository at this point in the history

  6. chore: version change just for testing

    @vesameskanen
    vesameskanen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    189dfc6 View commit details
    Browse the repository at this point in the history

  7. fix: no tabs in yaml

    @vesameskanen
    vesameskanen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    4cb4a47 View commit details
    Browse the repository at this point in the history

  8. fix: update slack message posting

    @vesameskanen
    vesameskanen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    27214d5 View commit details
    Browse the repository at this point in the history

  9. chore: test package publishing

    @vesameskanen
    vesameskanen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    2871cf4 View commit details
    Browse the repository at this point in the history

  10. chore: new test run

    @vesameskanen
    vesameskanen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    7973d8d View commit details
    Browse the repository at this point in the history

  11. chore: add debug messages

    @vesameskanen
    vesameskanen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    a8842ee View commit details
    Browse the repository at this point in the history

  12. fix: tab

    @vesameskanen
    vesameskanen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    7dbc433 View commit details
    Browse the repository at this point in the history

  13. chore: more debug messages

    @vesameskanen
    vesameskanen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    2041d62 View commit details
    Browse the repository at this point in the history

  14. fix: grep

    @vesameskanen
    vesameskanen committed Aug 15, 2023
    Configuration menu
    Copy the full SHA
    c7f1d3b View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2023

  1. chore: workflow is tested now, change ci tag back to v3

    @vesameskanen
    vesameskanen committed Aug 16, 2023
    Configuration menu
    Copy the full SHA
    5390378 View commit details
    Browse the repository at this point in the history

Commits on Aug 21, 2023

  1. Update .github/workflows/hotfix-pipeline.yml 

    Co-authored-by: Joel Lappalainen <[email protected]>
    @vesameskanen @optionsome
    vesameskanen and optionsome authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    bd0f7c9 View commit details
    Browse the repository at this point in the history

  2. Update .github/workflows/hotfix-pipeline.yml 

    Co-authored-by: Joel Lappalainen <[email protected]>
    @vesameskanen @optionsome
    vesameskanen and optionsome authored Aug 21, 2023
    Configuration menu
    Copy the full SHA
    aca2914 View commit details
    Browse the repository at this point in the history

  3. chore: remove internal health check

    @vesameskanen
    vesameskanen committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    772ccdb View commit details
    Browse the repository at this point in the history

  4. Revert "chore: remove internal health check" 

    This reverts commit 772ccdb.
    @vesameskanen
    vesameskanen committed Aug 21, 2023
    Configuration menu
    Copy the full SHA
    08a03ef View commit details
    Browse the repository at this point in the history