Import Jore 3 ids for lines and scheduled stop points #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was handled by cascade in scheduled stop point truncate. All other tables were truncated explicitly (even if they require cascade due to foreign keys). Might be a good idea to run all the truncates in same transaction to avoid this, enforcing doing each truncate explicitly without cascades.
Now there's two of those, with different signatures.
Fixes type of jr_pysakki.soltunnus: was 6 chars with test db but 7 in real Jore3.
That is, numbers (as strings), like they are in real jore3. Simply mapped 'a' -> '1000001', 'b' -> '1000002' and so on.
With external id that is.
More logical place, and now can test it better. Unfortunately we still need the original ID in string as well, since it is used to write the jore4 ids back to importer DB. Converting back to String instead would be flaky, eg. when there's padding with zeros.
Named "export" since this is used for exports (LIJ) in jore4. Not sure what the original idea of this in Jore3 has been, since it is not the primary key. In jore4 it is called external_id though, but that name already has another meaning here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves HSLdevcom/jore4#1187
This change is