Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Accessibility 2021 contributors #2489

Merged
merged 10 commits into from
Nov 16, 2021
Merged

Update Accessibility 2021 contributors #2489

merged 10 commits into from
Nov 16, 2021

Conversation

rviscomi
Copy link
Member

Progress on #2147

@rviscomi rviscomi added writing Related to wording and content project management Keeping the ball rolling labels Nov 14, 2021
@rviscomi rviscomi added this to the 2021 Launch 🚀 milestone Nov 14, 2021
@rviscomi rviscomi requested a review from alextait1 November 14, 2021 22:12
Comment on lines 5 to 7
authors: [alextait1]
reviewers: []
analysts: []
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alextait1 can you suggest edits to the Authors, Reviewers, and Analysts properties so that they contain everyone who contributed to the chapter, roughly ordered by those with the most significant contributions first? This is what readers will see at the top of the chapter so we want to be sure to give appropriate credit to everyone who helped.

alextait1 and others added 3 commits November 15, 2021 22:52
@@ -297,9 +316,17 @@
"github": "christianliebel",
"twitter": "christianliebel"
},
"digitala11ies": {
"name": "digitala11ies",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@digitala11ies would you like to be credited by your full name in the chapter, or any other personal info shared (website, twitter, etc)?

Comment on lines +363 to +370
"cdixon83": {
"name": "Carlie Dixon",
"teams": [
"reviewers"
],
"avatar_url": "https://avatars.githubusercontent.com/u/76669481?v=4&s=200",
"github": "cdixon83"
},
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cdixon83 FYI I've added your name but since it's not on your GitHub profile let me know if you'd rather go by something else

@@ -654,6 +712,14 @@
"github": "kevinfarrugia",
"twitter": "imkevdev"
},
"kachiden": {
"name": "Katriel Paige",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kachiden FYI I've added your name but since it's not on your GitHub profile let me know if you'd rather go by something else

@@ -674,6 +740,16 @@
"github": "LeaVerou",
"twitter": "leaverou"
},
"Zizzamia": {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is intentional, I forgot to add it in the Caching contributor PR 😅

@digitala11ies
Copy link

digitala11ies commented Nov 16, 2021 via email

@rviscomi
Copy link
Member Author

Oh ok sorry for the mixup @digitala11ies, wish you the best!

Updated contributors to include @estelle.

@alextait1
Copy link
Contributor

Oh ok sorry for the mixup @digitala11ies, wish you the best!

Updated contributors to include @estelle.

Thanks @rviscomi!

@rviscomi rviscomi merged commit 97cda48 into main Nov 16, 2021
@rviscomi rviscomi deleted the a11y-contributors branch November 16, 2021 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
project management Keeping the ball rolling writing Related to wording and content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants