Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to new datamodel #209

Merged
merged 26 commits into from
Jan 16, 2025
Merged

Upgrade to new datamodel #209

merged 26 commits into from
Jan 16, 2025

Conversation

tunetheweb
Copy link
Member

WIP as I rerun the reports

@tunetheweb
Copy link
Member Author

Think this is good to merge. It converts all reports and also simplifies the lens (particularly for blink_fetaures) considerably. We could further simplify the CrUX ones to always join to crawl.pages to allow filtering for lens (instead of adding a subquery) but think there's enough in here for now.

The only report that doesn't work with lenses is cruxShopifyThemes as that's a more complex query but it's not needed for each lens.

@max-ostapenko since you already spotted one typo do you wanna have a look over before I merge? Hopefully the queries will be easier to migrate to your better solution and we can stop using that hack of a shell script soon.

@max-ostapenko
Copy link
Contributor

Thanks for the effort here.
I found a few things I didn't catch, like special logic for CrUX lenses.

@tunetheweb tunetheweb merged commit 5230702 into master Jan 16, 2025
1 check passed
@tunetheweb tunetheweb deleted the upgrade-to-new-datamodel branch January 16, 2025 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants