Remove reference to avoid cloning

HULKs · Jun 13, 2023 · 1c5d298 · 1c5d298
1 parent b53651d
commit 1c5d298
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/crates/source_analyzer/src/cyclers.rs b/crates/source_analyzer/src/cyclers.rs
@@ -34,9 +34,9 @@ impl Cyclers {
         manifest: FrameworkManifest,
         root: impl AsRef<Path>,
     ) -> Result<Cyclers, Error> {
-        let values = &manifest.cyclers;
-        let cyclers = values
-            .iter()
+        let cyclers = manifest
+            .cyclers
+            .into_iter()
             .map(|manifest| Cycler::try_from_manifest(manifest, root.as_ref()))
             .collect::<Result<_, _>>()?;
         Ok(Self { cyclers })
@@ -94,10 +94,9 @@ pub struct Cycler {
 }
 
 impl Cycler {
-    fn try_from_manifest(cycler_manifest: &CyclerManifest, root: &Path) -> Result<Cycler, Error> {
+    fn try_from_manifest(cycler_manifest: CyclerManifest, root: &Path) -> Result<Cycler, Error> {
         let instance_names = cycler_manifest
             .instances
-            .clone()
             .unwrap_or_else(|| vec![String::new()]);
         let instances = instance_names
             .iter()
@@ -117,7 +116,7 @@ impl Cycler {
             .collect::<Result<Vec<_>, _>>()?;
 
         Ok(Cycler {
-            name: cycler_manifest.name.clone(),
+            name: cycler_manifest.name,
             kind: cycler_manifest.kind,
             instances,
             setup_nodes,