Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Camera Error Projection #1045

Merged
merged 7 commits into from
Jul 10, 2024
Merged

Conversation

oleflb
Copy link
Contributor

@oleflb oleflb commented Jun 1, 2024

Why? What?

Propagate measurement noise in the image through the camera matrix. This makes the uncertainty computation more exact. To account for the robot moving, the uncertainty in image coordinates is scaled by a filtered gyro velocity norm.

Depends on #1044.

Fixes #

ToDo / Known Issues

If this is a WIP describe which problems are to be fixed.

Ideas for Next Iterations (Not This PR)

If there are some improvements that could be done in a next iteration, describe them here.

How to Test

  • Put a ball in front of the robot and look at the new twix map overlay "Ball Measurements". The covariance is now dependent on the location of the ball relative to the robot. The ellipse is not correctly rotated, the issue is only in drawing, and will be fixed in Time error projected kalman filter #1036

@oleflb oleflb enabled auto-merge June 1, 2024 16:08
@oleflb oleflb force-pushed the ball_filter/camera_error_projection branch from 4237bdc to 09f057d Compare June 1, 2024 16:08
Copy link
Contributor

@schluis schluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 👌🏻

crates/projection/src/camera_projection.rs Show resolved Hide resolved
crates/types/src/ball.rs Outdated Show resolved Hide resolved
crates/projection/src/lib.rs Show resolved Hide resolved
crates/projection/src/lib.rs Show resolved Hide resolved
crates/vision/src/ball_detection.rs Show resolved Hide resolved
crates/vision/src/ball_detection.rs Outdated Show resolved Hide resolved
crates/vision/src/ball_detection.rs Show resolved Hide resolved
@oleflb oleflb force-pushed the ball_filter/camera_error_projection branch 3 times, most recently from 667e826 to f56a27b Compare July 10, 2024 10:44
@oleflb oleflb force-pushed the ball_filter/camera_error_projection branch from f56a27b to 9fdcf6c Compare July 10, 2024 17:48
Copy link
Contributor

@schluis schluis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like

@oleflb oleflb added this pull request to the merge queue Jul 10, 2024
Merged via the queue into HULKs:main with commit 260be52 Jul 10, 2024
25 checks passed
@oleflb oleflb deleted the ball_filter/camera_error_projection branch July 10, 2024 17:55
oleflb added a commit to oleflb/hulk that referenced this pull request Jul 15, 2024
* impl error projection

* add twix panel for debugging

* impl error projection

* rename

* rename 2

* add paper link

* fix twix

---------

Co-authored-by: okiwi6 <oleflb>
oleflb added a commit that referenced this pull request Sep 30, 2024
* impl error projection

* add twix panel for debugging

* impl error projection

* rename

* rename 2

* add paper link

* fix twix

---------

Co-authored-by: okiwi6 <oleflb>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants