Fix binary names #403
Merged
Fix binary names #403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced Changes
#182 changed the binary names which wasn't taken into account by the remote compilation feature in pepsi.
The webots controller symlink was also still pointing to the old binary name.
Previously the binaries were called
webotsandnao, now they arehulk_webotsandhulk_nao.Fixes #
ToDo / Known Issues
Ideas for Next Iterations (Not This PR)
How to Test
Remove left over binaries (or just
cargo clean), build, and check if the non-extern webots file works again.Same with
pepsi upload --remote. Make sure to clean the remote repo beforehand.