This repository has been archived by the owner on Nov 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 30
Eb deployment #23
Open
steve-louis
wants to merge
21
commits into
develop
Choose a base branch
from
eb_deployment
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Eb deployment #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is useful if the platform requires our app to listen on a specific port.
EB was not using our custom proxy config and expected our API on port 8080.
SSH Keys will be created during the EB INIT steps
Bad grammar
saurookadook
suggested changes
Feb 16, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@steve-louis This is awesome!!! Thank you so much for putting this together; I can already tell it's going to be a huge help to anyone who might use this repo (myself included 😂 ).
Overall, I would visit each page in GitHub to just make sure that the markdown is rendering correctly. I've noted a few places where it seems a typo or two might be causing problems with that.
Most of my other notes are just about maintaining consistency when referencing certain things. I tried to provide brief explanations in each, but let me know if you have any questions about them or want to make a case for something else 🙂
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the Elastic Beanstalk (Backend) deployment configuration files and documentation.
How to test
Follow instructions in the README files 😸
Also, check formatting of each of the README files starting here: