Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Radix UI setup #24

Merged
merged 6 commits into from
Oct 6, 2023
Merged

Radix UI setup #24

merged 6 commits into from
Oct 6, 2023

Conversation

samderanova
Copy link
Contributor

  • Installed Radix UI
  • Set default Radix font to Poppins via FontProvider

@samderanova samderanova linked an issue Sep 27, 2023 that may be closed by this pull request
Radix UI setup #23
Closed
@github-actions
Copy link

github-actions bot commented Sep 27, 2023 •
edited
Loading

Deploy preview for hack-ics-uci-edu ready!

Name Hack at UCI Site
Preview Visit Preview
Commit 26ddcea

@github-actions
Copy link

github-actions bot commented Sep 27, 2023 •
edited
Loading

Deploy preview for hack-ics-uci-edu-sanity ready!

Name Sanity Studio
Preview Visit Preview
Commit 26ddcea

@alexanderl19
Copy link
Contributor

I forgot that Radix released a new themes system. I'll take a deeper dive into it later and see if it's compatible with Server Components.

samderanova
samderanova commented Oct 2, 2023
View reviewed changes
Copy link
Contributor Author

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing to this! The accordion does look somewhat plain, but the customizability will definitely benefit us in the long run. Feel free to approve whenever you're ready.

apps/site/src/lib/theme/components/accordion/accordion.module.scss Outdated Show resolved Hide resolved
@alexanderl19
Copy link
Contributor

Thanks Sam! The accordion was just meant to be a placeholder to demonstrate how to style primitives. I'll fix the file name tomorrow and merge this.

Also I've run into quite a few instances where I think writing additional documentation would be helpful. After ZotHacks, could we explore some documentation solutions?

@samderanova
Copy link
Contributor Author

Thanks Sam! The accordion was just meant to be a placeholder to demonstrate how to style primitives. I'll fix the file name tomorrow and merge this.

Also I've run into quite a few instances where I think writing additional documentation would be helpful. After ZotHacks, could we explore some documentation solutions?

Yes, that would be helpful! I'll make a note to do this when the time comes.

@alexanderl19 alexanderl19 requested review from tyleryy and removed request for alexanderl19 October 4, 2023 19:29
@tyleryy
Copy link
Contributor

tyleryy commented Oct 4, 2023 •
edited
Loading

Building off the need for documentation, I feel like some single source of truth for past projects, practices, components would be great for future generations of developers on the Tech team. That way there is some reusability that can be used and we don't have to build everything from scratch.

@alexanderl19 alexanderl19 merged commit 93c9388 into main Oct 6, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexanderl19 alexanderl19 alexanderl19 left review comments

@tyleryy tyleryy tyleryy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Radix UI setup
3 participants
@samderanova @alexanderl19 @tyleryy