Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added generalized flow for applications #453

Merged
merged 4 commits into from
Dec 9, 2024
Merged

Added generalized flow for applications #453

merged 4 commits into from
Dec 9, 2024

Conversation

IanWearsHat
Copy link
Member

@IanWearsHat IanWearsHat commented Dec 9, 2024 •
edited
Loading

Created generalized flow for applications.

Intention is to use apply_flow function with each application route.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 9, 2024 •
edited
Loading

Deploy preview for irvinehacks-site-2025 ready!

Name IrvineHacks Site
Preview Visit Preview
Commit 609aef2

@IanWearsHat IanWearsHat marked this pull request as draft December 9, 2024 01:55
Bl20052005
Bl20052005 previously approved these changes Dec 9, 2024
View reviewed changes
@IanWearsHat IanWearsHat marked this pull request as ready for review December 9, 2024 02:28
taesungh
taesungh reviewed Dec 9, 2024
View reviewed changes
apps/api/src/routers/user.py Show resolved Hide resolved
apps/api/src/routers/user.py Outdated Show resolved Hide resolved
taesungh
taesungh approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@taesungh taesungh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor notes, can address later if in a rush.

apps/api/src/routers/user.py Show resolved Hide resolved
apps/api/src/routers/user.py Show resolved Hide resolved
apps/site/src/lib/components/forms/shared/BaseForm.tsx Show resolved Hide resolved
apps/site/src/lib/components/forms/shared/BaseForm.tsx Show resolved Hide resolved
@taesungh taesungh mentioned this pull request Dec 9, 2024
Merged
@IanWearsHat IanWearsHat removed the request for review from waalbert December 9, 2024 07:16
@IanWearsHat IanWearsHat merged commit 3a86ef9 into main Dec 9, 2024
4 checks passed
This was referenced Dec 9, 2024
Closed
Closed
@waalbert waalbert mentioned this pull request Dec 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@waalbert waalbert waalbert left review comments

@taesungh taesungh taesungh approved these changes

@Bl20052005 Bl20052005 Bl20052005 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@IanWearsHat @taesungh @waalbert @Bl20052005