Reorganize search params for server components #528
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rams from GuestLogin page
|
Deploy preview for irvinehacks-site-2025 ready!
|
IanWearsHat
previously approved these changes
Dec 24, 2024
taesungh
changed the title
GuestLoginVerificationForm to server component
taesungh
approved these changes
Dec 24, 2024
taesungh
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
useSearchParamsinGuestLoginVerificationFormsearchParamsfromGuestLoginand passessearchParamsas props toGuestLoginVerificationFormGuestLoginVerificationFormto no longer need to be a client componentsearchParamsas optional as Next.js always provides this to page componentssearchParamsbefore using query parametersCloses #521 and unblocks #403 to allow upgrading to Next.js 14.