Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat/organizer carousel #535

Merged
merged 12 commits into from
Jan 26, 2025
Merged

Feat/organizer carousel #535

merged 12 commits into from
Jan 26, 2025

Conversation

pandyrew
Copy link
Contributor

@pandyrew pandyrew commented Jan 1, 2025

Fun Organizer Carousel!

I put all the images and names and departments into sanity so I hope it works. I added localhost:3000 to the CORS origins in the sanity dashboard because i was running into CORS issues. LMK if there are better solutions.

Also I added Images to be optimized by next in the next.config. Only from Sanity.

Pictures that aren't added (as in if they weren't in the Zothacks headshots) are replaced with a placeholder: volunteer_sprite.png. Maybe we can pick a different one.

Screenshot 2024-12-31 at 5 18 30 PM

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 1, 2025 •
edited
Loading

Deploy preview for irvinehacks-site-2025 ready!

Name IrvineHacks Site
Preview Visit Preview
Commit 9ca8b30

@waalbert
Copy link
Contributor

waalbert commented Jan 6, 2025

Regarding your comment about needing to add localhost:3000 to CORS, the reason you have to do that is because you're using next/image and added cdn.sanity.io to next.config.js to optimize the images. We didn't have to worry about CORS in the past because we have our Sanity dataset exposed to the public, so we're able to use Sanity Client along with regular <img> tags. Our Sanity Client is configured to use Sanity's API CDN, so using Next to optimize images might not be needed as I'm not sure if Next can provide meaningful performance improvements.

@pandyrew pandyrew force-pushed the feat/organizer-carousel branch from a1c63e1 to ccceba5 Compare January 18, 2025 20:23
github-actions[bot]
github-actions bot reviewed Jan 26, 2025
View reviewed changes
apps/site/src/app/(main)/(home)/sections/InfiniteMovingCards.tsx
}) => {
const containerRef = React.useRef<HTMLDivElement>(null);
const scrollerRef = React.useRef<HTMLUListElement>(null);
const [start, setStart] = useState(false);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ [eslint] <@typescript-eslint/no-unused-vars> reported by reviewdog 🐶
'start' is assigned a value but never used.

waalbert
waalbert approved these changes Jan 26, 2025
View reviewed changes
Copy link
Contributor

@waalbert waalbert left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merging to show to the public

@waalbert waalbert merged commit 685d786 into main Jan 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@waalbert waalbert waalbert approved these changes

@taesungh taesungh Awaiting requested review from taesungh

@IanWearsHat IanWearsHat Awaiting requested review from IanWearsHat

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pandyrew @waalbert