Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor/status values #583

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

refactor/status values #583

wants to merge 2 commits into from

Conversation

jotalis
Copy link
Contributor

@jotalis jotalis commented Jan 20, 2025

Summary

  • Replaced PortalStatus in ApplicantPortal.tsx with entire site's Status reference
  • Removed unused RELEASED
  • Converted to switch statements in Message.tsx and VerdictComponent for exhaustiveness checking
  • Added pre-release statuses (pending and reviewed) to ApplicantSummary donut chart
  • Refactored Status enums to be PascalCase

Test Plan

  • Disable the ApplicationsClosed check in ApplicationFlow.tsx
  • Create a user in local db, e.g.,
    { _id: 'edu.uci.test', status: 'VOID', roles: [ 'Applicant' ], first_name: 'john', last_name: 'doe' }
  • Impersonate user on dev -> /api/dev/impersonate/test
  • Ensure correct components are displayed

Closes #520

Copy link
Contributor

Deploy preview for irvinehacks-site-2025 ready!

Name IrvineHacks Site
Preview Visit Preview
Commit 9e31012

@jotalis jotalis requested review from waalbert and taesungh January 20, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reorganize usage of Status values throughout site
1 participant