Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create reusable action derived from turbo-ignore #1

Merged
merged 3 commits into from
Dec 8, 2024
Merged

Create reusable action derived from turbo-ignore #1

merged 3 commits into from
Dec 8, 2024

Conversation

taesungh
Copy link
Member

@taesungh taesungh commented Dec 8, 2024

Originally desired in HackAtUCI/zothacks-site#209 and HackAtUCI/irvinehacks-site#439.

Changes

  • Create new composite action improving upon Turborepo's turbo-ignore
  • Compare hashes at the task level rather than only filtering packages
  • Provide a step output of a status flag, similar to the exit codes

Testing

  1. Tested with personal fork of HackAtUCI/irvinehacks-site using a workflow with steps similar to the sample usage
  2. Observed deployment could be skipped for a non-functional modification such as updating a README file
  3. Observed deployment could not be skipped for a functional modification such as a relevant code change

@taesungh
Create reusable action derived from turbo-ignore
96bd2a2 
- Create new composite action improving upon Turborepo's turbo-ignore
- Compare hashes at the task level rather than only filtering packages
- Provide a step output of a status flag, similar to the exit codes
@taesungh taesungh requested a review from samderanova December 8, 2024 02:55
samderanova
samderanova reviewed Dec 8, 2024
View reviewed changes
super-turbo-ignore.js Outdated Show resolved Hide resolved
super-turbo-ignore.js Outdated Show resolved Hide resolved
super-turbo-ignore.js Outdated Show resolved Hide resolved
@taesungh
Switch from using Node and npx to bun and bunx
99ef5c0 
- Bun can directly execute TypeScript code instead of needing ts-node
  - Overall execution also seems slightly faster
- Add `package.json` for dev-dependency on `@types/node`
- Move types directly into script and fix type errors
- Remove `npm-cache-dependency-path` parameter in action inputs
@taesungh taesungh mentioned this pull request Dec 8, 2024
Open
@taesungh taesungh requested a review from samderanova December 8, 2024 19:53
samderanova
samderanova requested changes Dec 8, 2024
View reviewed changes
Copy link

@samderanova samderanova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me other than the one small nitpick!

Were you able to test whether this works or not or do you plan on testing it in the IrvineHacks site repo?

action.yml Outdated Show resolved Hide resolved
@taesungh
Copy link
Member Author

taesungh commented Dec 8, 2024

Yes, tested with a personal fork of the IrvineHacks site (and a fork of this action's repository) as noted in the PR description.

@taesungh taesungh merged commit bf530bc into main Dec 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samderanova samderanova samderanova approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@taesungh @samderanova