-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Set up Home page content including Landing #21
Conversation
* feat: create navigation bar * feat: create footer * refactor: font, dependencies, scss, footer * fix: navbar on mobile * refactor: added routes and other small changes * feat: active page link has corresponding color * feat: add ZotHacks logo * fix: use responsive css and add bold weight * chore: use absolute asset path for navbar background * fix: logo moves upon navbar expansion and navbar is fixed to top of the screen * refactor: clean up css and use bootstrap grid * fix: remove horizontal scroll * fix: switch Twitter to Hack and SVG to PNG * fix: move Hack to front of footer --------- Co-authored-by: Alexander Liu <[email protected]> feat: text centered feat: added apply button svg to assets Bootstrap Sass Organization (#17) * feat: bootstrap sass organization * fix: installed bootstrap * fix: import font from Next instead of Google Fonts * fix: update red hex value correctly * linting * fix: custom CSS property for font * fix: sass partials * fix: new sass path, incorporated navbar and footer * fix: removed comment --------- Co-authored-by: Tyler Yu <[email protected]> feat: apply button
…acks-site-2023 into feature/home-page
Deploy preview for zothacks-site-2023 ready!
|
Deploy preview for zothacks-site-2023-sanity ready!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great start so far! Just a few suggestions:
apps/site/src/views/Landing/components/ApplyButton/ApplyButton.module.scss
Outdated
Show resolved
Hide resolved
apps/site/src/views/Landing/components/ApplyButton/ApplyButton.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Decent start on the button design. A few organizational and usage notes.
apps/site/src/views/Landing/components/ApplyButton/ApplyButton.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/views/Landing/components/ApplyButton/ApplyButton.module.scss
Outdated
Show resolved
Hide resolved
apps/site/src/views/Landing/components/ApplyButton/ApplyButton.module.scss
Outdated
Show resolved
Hide resolved
apps/site/src/views/Landing/components/ApplyButton/ApplyButton.module.scss
Outdated
Show resolved
Hide resolved
apps/site/src/views/Landing/components/ApplyButton/ApplyButton.tsx
Outdated
Show resolved
Hide resolved
apps/site/src/views/Landing/components/ApplyButton/ApplyButton.module.scss
Outdated
Show resolved
Hide resolved
apps/site/src/views/Landing/components/ApplyButton/ApplyButton.module.scss
Outdated
Show resolved
Hide resolved
apps/site/src/views/Landing/components/ApplyButton/ApplyButton.module.scss
Outdated
Show resolved
Hide resolved
fix: removed bootstrap imports fix: removed unused asset fix: removed apply button container div fix: added warning variant fix: 0.7 opacity on apply button fix: native HTML button instead of Bootstrap fix: opacity applied to background only + height change
- To match common naming, rename primary page to Home - Landing is now the first view of the Home page - Wrap primary layout children in `<main>`
- Add `Container` elements for sections with responsive vertical padding
- Use `bootstrap.button-variant` mixin for Apply button styles - Specify empty variant to React Bootstrap - Remove unnecessary sizing and layout styles
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the hard work on this! As a suggestion, we could also make a custom Container
component that has as
set to "section"
by default so we don't have to keep typing it out when we need to and have the custom padding.
Also, one small change to make:
* feat: bootstrap sass organization * fix: installed bootstrap * fix: import font from Next instead of Google Fonts * fix: update red hex value correctly * linting * fix: custom CSS property for font * fix: sass partials * fix: new sass path, incorporated navbar and footer * fix: removed comment --------- Co-authored-by: Tyler Yu <[email protected]> Add tiling anteater head background art (#25) - Make diagonally tiling base asset to use native CSS background repeat - Embed white background to minimize opaque file size (no transparency) - The resulting GIF uses 8 colors with dithering Co-authored-by: Taesung Hwang <[email protected]> Set up Home page content including Landing (#21) Set up Home page content including Landing - Reorganize Landing into Home - To match common naming, rename primary page to Home - Landing is now the first view of the Home page - Wrap primary layout children in `<main>` - Use container layout for Home page sections - Add `Container` elements for sections w/ responsive vertical padding - Create yellow Apply button with bs-btn variant in Home page Landing - Use `bootstrap.button-variant` mixin for Apply button styles - Specify empty variant to React Bootstrap - Remove unnecessary sizing and layout styles - Separate usage of theme variables and Bootstrap mixins --------- Co-authored-by: Taesung Hwang <[email protected]>
* feat: bootstrap sass organization * fix: installed bootstrap * fix: import font from Next instead of Google Fonts * fix: update red hex value correctly * linting * fix: custom CSS property for font * fix: sass partials * fix: new sass path, incorporated navbar and footer * fix: removed comment --------- Co-authored-by: Tyler Yu <[email protected]> Add tiling anteater head background art (#25) - Make diagonally tiling base asset to use native CSS background repeat - Embed white background to minimize opaque file size (no transparency) - The resulting GIF uses 8 colors with dithering Co-authored-by: Taesung Hwang <[email protected]> Set up Home page content including Landing (#21) Set up Home page content including Landing - Reorganize Landing into Home - To match common naming, rename primary page to Home - Landing is now the first view of the Home page - Wrap primary layout children in `<main>` - Use container layout for Home page sections - Add `Container` elements for sections w/ responsive vertical padding - Create yellow Apply button with bs-btn variant in Home page Landing - Use `bootstrap.button-variant` mixin for Apply button styles - Specify empty variant to React Bootstrap - Remove unnecessary sizing and layout styles - Separate usage of theme variables and Bootstrap mixins --------- Co-authored-by: Taesung Hwang <[email protected]>
* feat: bootstrap sass organization * fix: installed bootstrap * fix: import font from Next instead of Google Fonts * fix: update red hex value correctly * linting * fix: custom CSS property for font * fix: sass partials * fix: new sass path, incorporated navbar and footer * fix: removed comment --------- Co-authored-by: Tyler Yu <[email protected]> Add tiling anteater head background art (#25) - Make diagonally tiling base asset to use native CSS background repeat - Embed white background to minimize opaque file size (no transparency) - The resulting GIF uses 8 colors with dithering Co-authored-by: Taesung Hwang <[email protected]> Set up Home page content including Landing (#21) Set up Home page content including Landing - Reorganize Landing into Home - To match common naming, rename primary page to Home - Landing is now the first view of the Home page - Wrap primary layout children in `<main>` - Use container layout for Home page sections - Add `Container` elements for sections w/ responsive vertical padding - Create yellow Apply button with bs-btn variant in Home page Landing - Use `bootstrap.button-variant` mixin for Apply button styles - Specify empty variant to React Bootstrap - Remove unnecessary sizing and layout styles - Separate usage of theme variables and Bootstrap mixins --------- Co-authored-by: Taesung Hwang <[email protected]>
author Albert Wang <[email protected]> 1694217932 -0700 committer Tyler Yu <[email protected]> 1695095646 -0700 draft: sticker component + animations + layout * feat: create navigation bar * feat: create footer * refactor: font, dependencies, scss, footer * fix: navbar on mobile * refactor: added routes and other small changes * feat: active page link has corresponding color * feat: add ZotHacks logo * fix: use responsive css and add bold weight * chore: use absolute asset path for navbar background * fix: logo moves upon navbar expansion and navbar is fixed to top of the screen * refactor: clean up css and use bootstrap grid * fix: remove horizontal scroll * fix: switch Twitter to Hack and SVG to PNG * fix: move Hack to front of footer --------- Co-authored-by: Alexander Liu <[email protected]> feat: draggable sticker component fix: pull from main * feat: bootstrap sass organization * fix: installed bootstrap * fix: import font from Next instead of Google Fonts * fix: update red hex value correctly * linting * fix: custom CSS property for font * fix: sass partials * fix: new sass path, incorporated navbar and footer * fix: removed comment --------- Co-authored-by: Tyler Yu <[email protected]> Add tiling anteater head background art (#25) - Make diagonally tiling base asset to use native CSS background repeat - Embed white background to minimize opaque file size (no transparency) - The resulting GIF uses 8 colors with dithering Co-authored-by: Taesung Hwang <[email protected]> Set up Home page content including Landing (#21) Set up Home page content including Landing - Reorganize Landing into Home - To match common naming, rename primary page to Home - Landing is now the first view of the Home page - Wrap primary layout children in `<main>` - Use container layout for Home page sections - Add `Container` elements for sections w/ responsive vertical padding - Create yellow Apply button with bs-btn variant in Home page Landing - Use `bootstrap.button-variant` mixin for Apply button styles - Specify empty variant to React Bootstrap - Remove unnecessary sizing and layout styles - Separate usage of theme variables and Bootstrap mixins --------- Co-authored-by: Taesung Hwang <[email protected]> feat: draggable sticker enhancements feat: sticker dragConstraints and elastic added type sticker spring transition reduced spring stiffness shadow adjustments feat: base sticker component individual sticker example rename to Base Sticker imports feat: sticker layout, file structure, animations hoisted transition object hack sticker w/ light shake animation heart sticker quickshake animation animation transition timing adjustments positioning on stickerLayout Navigation Bar and Footer (#14) * feat: create navigation bar * feat: create footer * refactor: font, dependencies, scss, footer * fix: navbar on mobile * refactor: added routes and other small changes * feat: active page link has corresponding color * feat: add ZotHacks logo * fix: use responsive css and add bold weight * chore: use absolute asset path for navbar background * fix: logo moves upon navbar expansion and navbar is fixed to top of the screen * refactor: clean up css and use bootstrap grid * fix: remove horizontal scroll * fix: switch Twitter to Hack and SVG to PNG * fix: move Hack to front of footer --------- Co-authored-by: Alexander Liu <[email protected]> feat: sticker start + framer install feat: draggable sticker component Bootstrap Sass Organization (#17) * feat: bootstrap sass organization * fix: installed bootstrap * fix: import font from Next instead of Google Fonts * fix: update red hex value correctly * linting * fix: custom CSS property for font * fix: sass partials * fix: new sass path, incorporated navbar and footer * fix: removed comment --------- Co-authored-by: Tyler Yu <[email protected]> Add tiling anteater head background art (#25) - Make diagonally tiling base asset to use native CSS background repeat - Embed white background to minimize opaque file size (no transparency) - The resulting GIF uses 8 colors with dithering Co-authored-by: Taesung Hwang <[email protected]> Set up Home page content including Landing (#21) Set up Home page content including Landing - Reorganize Landing into Home - To match common naming, rename primary page to Home - Landing is now the first view of the Home page - Wrap primary layout children in `<main>` - Use container layout for Home page sections - Add `Container` elements for sections w/ responsive vertical padding - Create yellow Apply button with bs-btn variant in Home page Landing - Use `bootstrap.button-variant` mixin for Apply button styles - Specify empty variant to React Bootstrap - Remove unnecessary sizing and layout styles - Separate usage of theme variables and Bootstrap mixins --------- Co-authored-by: Taesung Hwang <[email protected]> feat: sticker start + framer install feat: draggable sticker component removed use state import Bootstrap Sass Organization (#17) * feat: bootstrap sass organization * fix: installed bootstrap * fix: import font from Next instead of Google Fonts * fix: update red hex value correctly * linting * fix: custom CSS property for font * fix: sass partials * fix: new sass path, incorporated navbar and footer * fix: removed comment --------- Co-authored-by: Tyler Yu <[email protected]> Add tiling anteater head background art (#25) - Make diagonally tiling base asset to use native CSS background repeat - Embed white background to minimize opaque file size (no transparency) - The resulting GIF uses 8 colors with dithering Co-authored-by: Taesung Hwang <[email protected]> Set up Home page content including Landing (#21) Set up Home page content including Landing - Reorganize Landing into Home - To match common naming, rename primary page to Home - Landing is now the first view of the Home page - Wrap primary layout children in `<main>` - Use container layout for Home page sections - Add `Container` elements for sections w/ responsive vertical padding - Create yellow Apply button with bs-btn variant in Home page Landing - Use `bootstrap.button-variant` mixin for Apply button styles - Specify empty variant to React Bootstrap - Remove unnecessary sizing and layout styles - Separate usage of theme variables and Bootstrap mixins --------- Co-authored-by: Taesung Hwang <[email protected]> feat: draggable sticker component feat: sticker dragConstraints and elastic added type sticker spring transition reduced spring stiffness shadow adjustments feat: base sticker component individual sticker example rename to Base Sticker imports Navigation Bar and Footer (#14) * feat: create navigation bar * feat: create footer * refactor: font, dependencies, scss, footer * fix: navbar on mobile * refactor: added routes and other small changes * feat: active page link has corresponding color * feat: add ZotHacks logo * fix: use responsive css and add bold weight * chore: use absolute asset path for navbar background * fix: logo moves upon navbar expansion and navbar is fixed to top of the screen * refactor: clean up css and use bootstrap grid * fix: remove horizontal scroll * fix: switch Twitter to Hack and SVG to PNG * fix: move Hack to front of footer --------- Co-authored-by: Alexander Liu <[email protected]> feat: sticker start + framer install feat: draggable sticker component Add tiling anteater head background art (#25) - Make diagonally tiling base asset to use native CSS background repeat - Embed white background to minimize opaque file size (no transparency) - The resulting GIF uses 8 colors with dithering Co-authored-by: Taesung Hwang <[email protected]> linting fix: removed unused import
Overview
Created a rough draft of the apply button and layout for home page sections.
Details
Home page layout uses Bootstrap Container and Rows to organize sections into a single column down the middle.
Misc.
I want to make the apply button more "eye-catching" but for happy path it's good enough for now.