-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 2019 version #118
Open
querenker
wants to merge
205
commits into
HackHPI:main
Choose a base branch
from
querenker:master
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Fix 2019 version #118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Just to check whether 'assets' might be reserved in Jekyll and based on finding an assets folder, GitHub Pages makes some weird assumptions about what kind of other files it expects in the project.
For hhpi2017.html I used index.html from commit 0e40251 with minor changes to link in the 2017 version of the HackHPI logo etc.
Obtained by Google Chrome "Save Page As..."
Add updated favicon Remove "live" link See HackHPI#3
Add 2016 and 2017 favicons See HackHPI#3
Fixes HackHPI#11
Also some small difference in wording on the imprint page.
Visual and Navigation improvements
- Put the navbar links in the right order - Use display: table for an element in the location section so that the pixel height value of the section is rounded to the closest integer (it seems like the decimal pixel height value caused the issue with wrong sections being highlighted), this hinted at me at the solution: https://stackoverflow.com/a/13103868 (decimal height value is yielded by bootstrap class 'img-responsive' inside location-card
… level, added some pictures to fit live-page look
…ackHPI#115) * added api docs for mTomady, fixed favicon resource not found issue * fixed typo in useful * added faq presentations * fixed centering the live page button * minor change
* added fenja * added judging criteria to faq
* removed live site link * replaced bfdw logo with bfdw text * added redirect from live site to main page
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
By creating the 2022 version and moving the 2019 version to the archive, several links were broken. In addition, some files were directly modified for the new version, which breaks the design of the 2019 version.
Link: https://hackhpi.org/2019/
Screenshot
What was done?