Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2019 version #118

Open
wants to merge 205 commits into
base: main
Choose a base branch
from
Open

Fix 2019 version #118

wants to merge 205 commits into from

Conversation

querenker
Copy link

Problem Description

By creating the 2022 version and moving the 2019 version to the archive, several links were broken. In addition, some files were directly modified for the new version, which breaks the design of the 2019 version.

Link: https://hackhpi.org/2019/

Screenshot

hackhpi-broken-2019

What was done?

  • fixed relative paths to point correctly to the asset directory
  • renamed the modified 2019 style file to style-2022 and adjust references
  • get the original style files, partner information and logos back from the git history

Jakob Edding and others added 30 commits December 9, 2017 11:36
Just to check whether 'assets' might be reserved in Jekyll and based on finding
an assets folder, GitHub Pages makes some weird assumptions about what kind of
other files it expects in the project.
For hhpi2017.html I used index.html from commit 0e40251
with minor changes to link in the 2017 version of the HackHPI logo etc.
Obtained by Google Chrome "Save Page As..."
Add updated favicon
Remove "live" link

See HackHPI#3
Add 2016 and 2017 favicons

See HackHPI#3
Also some small difference in wording on the imprint page.
Visual and Navigation improvements
- Put the navbar links in the right order
- Use display: table for an element in the location section so that
the pixel height value of the section is rounded to the closest integer
(it seems like the decimal pixel height value caused the issue with
wrong sections being highlighted), this hinted at me at the solution:
https://stackoverflow.com/a/13103868 (decimal height value is yielded
by bootstrap class 'img-responsive' inside location-card
tommartensen and others added 29 commits May 12, 2019 15:46
… level, added some pictures to fit live-page look
…ackHPI#115)

* added api docs for mTomady, fixed favicon resource not found issue

* fixed typo in useful

* added faq presentations

* fixed centering the live page button

* minor change
* added fenja

* added judging criteria to faq
* removed live site link

* replaced bfdw logo with bfdw text

* added redirect from live site to main page
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants