Skip to content

Commit

Permalink
contrib/rdmacm-mux: fix clang compilation
Browse files Browse the repository at this point in the history
Fix Commit a5d2f6f (contrib/rdmacm-mux: Add implementation
                       of RDMA User MAD multiplexer).

The above commit introduces a new contrib target, adding a global dependency
to libumad library in case pvrdma configuration option is enabled.
Clang forbids it:
    clang-6.0: error: -libumad: 'linker' input unused
              [-Werror,-Wunused-command-line-argument]

Fix by limiting the scope to the rdmacm-mux target itself.

Reported-by: Cornelia Huck <[email protected]>
Reviewed-by: Yuval Shaia <[email protected]>
Tested-by: Cornelia Huck <[email protected]>
Message-Id: <[email protected]>
Signed-off-by: Marcel Apfelbaum <[email protected]>
  • Loading branch information
marcel-apf committed Jan 19, 2019
1 parent 555b3d6 commit 0f645ba
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 1 deletion.
2 changes: 2 additions & 0 deletions Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -581,6 +581,8 @@ vhost-user-scsi$(EXESUF): $(vhost-user-scsi-obj-y) libvhost-user.a
$(call LINK, $^)
vhost-user-blk$(EXESUF): $(vhost-user-blk-obj-y) libvhost-user.a
$(call LINK, $^)

rdmacm-mux$(EXESUF): LIBS += "-libumad"
rdmacm-mux$(EXESUF): $(rdmacm-mux-obj-y) $(COMMON_LDADDS)
$(call LINK, $^)

Expand Down
1 change: 0 additions & 1 deletion contrib/rdmacm-mux/Makefile.objs
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
ifdef CONFIG_PVRDMA
CFLAGS += -libumad
rdmacm-mux-obj-y = main.o
endif

0 comments on commit 0f645ba

Please sign in to comment.