Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

So it begins.. Hai on HackerOne #1

Merged
merged 16 commits into from
Jun 17, 2024
Merged

So it begins.. Hai on HackerOne #1

merged 16 commits into from
Jun 17, 2024

Conversation

iMartzen
Copy link
Member

@iMartzen iMartzen commented Jun 13, 2024

This is the start of the public repo, which contains a toolset for working with HackerOne's API and leveraging Hai through the API. This project is built during a hack week.

It's called: Hai On HackerOne.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ This pull request was sent to the PullRequest network for review. Expert reviewers are now being matched to your request based on the code's requirements. Stay tuned!

What to expect from this code review:
  • Comments posted to any areas of potential concern or improvement.
  • Detailed feedback or actions needed to resolve issues that are found.
  • Turnaround times vary, but we aim to be swift.

@iMartzen you can click here to see the review status or cancel the code review job.

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest Breakdown

Reviewable lines of change

+ 1,562
- 0

57% Python
25% Python (tests)
13% Markdown
1% Dockerfile
4% Other

Type of change

Feature - These changes are adding a new feature or improvement to existing code.
1 Message
⚠️ Due to its size, this pull request will likely have a little longer turnaround time and will probably require multiple passes from our reviewers.

@iMartzen iMartzen self-assigned this Jun 13, 2024
@iMartzen iMartzen changed the title So it begins.. So it begins.. Hai on HackerOne Jun 13, 2024
Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR introduces lots of new functionality, and is nicely documented and laid out!

I didn't find any critical bugs, made a number of suggestions around best practices and readability that will avoid future bugs and make this project much easier to maintain!

Image of Andrew N Andrew N


Reviewed with ❤️ by PullRequest

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I took a quick first look at the changes and wanted to post the feedback I have so far. I will take another look soon and provide more feedback. Thank you!

Image of Jonah Jonah


Reviewed with ❤️ by PullRequest

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest reviewed the updates made to #1 up until the latest commit (c22c02e). No further issues were found.

Reviewed by:

Image of Jonah Jonah

Copy link

@pullrequest pullrequest bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PullRequest reviewed the updates made to #1 up until the latest commit (5c48a78). No further issues were found.

Reviewed by:

Image of Andrew N Andrew N

Co-authored-by: Martijn Russchen <[email protected]>
@iMartzen iMartzen merged commit 948c638 into main Jun 17, 2024
@iMartzen iMartzen deleted the initialization branch June 17, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants