Skip to content
This repository has been archived by the owner on Mar 29, 2022. It is now read-only.

Non scoring PRs for winning or completed users #382

Open
wants to merge 13 commits into
base: master
Choose a base branch
from

Conversation

fridaland
Copy link
Contributor

In the case of a completed/winning user, a bonus nonscoring PR can potentially be lost. This would happen when an originally valid PR is marked as invalid or lost and then this bonus nonscoring PR would be bumped to scoring PRs. However, the user will simply see his bonus PR disappear in UI.

This PR refactors non_scoring_pull_requests to take a completed_or_winning user's PRs and compare them against their receipt to calculate their bonus PRs.

@fridaland fridaland changed the title Non scoring prs optimization Non scoring PRs for winning or completed users Oct 30, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants