Skip to content
This repository has been archived by the owner on May 22, 2020. It is now read-only.

RUN-5679 BrowserView => View #982

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/browser/api/browser_view.ts
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ import {
addBrowserView, getBrowserViewByIdentity, getWindowByUuidName, OfView, removeBrowserView,
updateViewTarget, getInfoByUuidFrame
} from '../core_state';
import { BrowserViewCreationOptions } from '../../../js-adapter/src/api/browserview/browserview';
import { ViewCreationOptions } from '../../../js-adapter/src/api/view/view';
import convertOptions = require('../convert_options');
import { getInfo as getWebContentsInfo, setIframeHandlers, hookWebContentsEvents} from './webcontents';
import of_events from '../of_events';
Expand All @@ -16,7 +16,7 @@ import { downloadScripts } from '../preload_scripts';

const windowCloseListenerMap: WeakMap<OpenFinWindow, WeakMap<OfView, () => void>> = new WeakMap();

export type BrowserViewOpts = WebOptions & BrowserViewCreationOptions;
export type BrowserViewOpts = WebOptions & ViewCreationOptions;
export async function create(options: BrowserViewOpts) {
// checking if the name-uuid combination is already in use
const { uuid, name } = options;
Expand Down
2 changes: 1 addition & 1 deletion src/browser/remote_subscriptions.ts
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ async function getClassEventEmitter(subscription: RemoteSubscription, runtime: P
classEventEmitter = await runtime.fin.Window.wrap({uuid, name});
break;
case 'view':
classEventEmitter = runtime.fin.BrowserView.wrapSync({uuid, name});
classEventEmitter = runtime.fin.View.wrapSync({uuid, name});
}

return classEventEmitter;
Expand Down