Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

github action tests #142

Open
n-a-t-e opened this issue Feb 8, 2023 · 1 comment
Open

github action tests #142

n-a-t-e opened this issue Feb 8, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@n-a-t-e
Copy link
Member

n-a-t-e commented Feb 8, 2023 •
edited
Loading

Testing the views:
A github action could test the views by running them, inside a transaction, on the database. Would be run on any pull requests and/or commits to main. Login information would be stored in github secrets.

Testing the XML snippets:
Run through XML linter
@n-a-t-e n-a-t-e added the enhancement New feature or request label Feb 8, 2023
@n-a-t-e n-a-t-e changed the title github action to test views github action tests Feb 8, 2023
@JessyBarrette JessyBarrette mentioned this issue Apr 20, 2023
Closed
10 tasks
JessyBarrette added a commit that referenced this issue Apr 21, 2023
@JessyBarrette
add workflow to test run erddap views #142
f136c6c
@JessyBarrette
Copy link
Contributor

I added a workflow that relies on defined github secrets to provide database connection. What you think?

@fostermh you may be interested by this

https://github.com/HakaiInstitute/hakai-datasets/blob/f136c6c7972c4172ce838ed10d27e8e4957b2378/.github/workflows/test-erddap-views.yaml

@JessyBarrette JessyBarrette linked a pull request Nov 3, 2023 that will close this issue
fix db views, table build test #161
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix db views, table build test HakaiInstitute/hakai-erddap
2 participants
@n-a-t-e @JessyBarrette