-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(node): ensure exported object is indeed an object and is a semantic-release configuration #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- remove Jest settings - remove Jest extension recommendations - remove vscode-jest-test launch config
No longe needed for this project, but they should be whitelisted in the gitignore templates anyway.
Run Script: start already handles it
I've had it up to here with other devs assuming I'm willing to use Jest. GET. OUT.
- use tsconfig.test.json - assume jest version 1 to resolve error when Jest is missing I can't be bothered to use the complex resolutions for errors raised by eslint-plugin-jest. We don't use Jest and we never will.
- tsconfig.cjs.json - emit declarations - tsconfig.json - do not emit declarations - tsconfig.test.json - extend from tsconfig.json - fix tests blob
dotnet, node, vscode
sourcemaps .d.ts files to .ts source files
This should resolve the "parentAlreadyFinished" issue present in our GitHub workflows
BinToss
changed the title
Packemon-ify
fix(node): ensure exported object is indeed an object and is a semantic-release configuration
Oct 18, 2023
test runners may run this script after detecting changes. Just `npm run watch`
It still doesn't work on my PC...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reworked just about everything.
resolves #16