-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update sqlmodel.cpp #80
base: master
Are you sure you want to change the base?
Conversation
change private parameters initial sequence.
src/sqlmodel.cpp
Outdated
@@ -122,7 +122,7 @@ Row<Table> SqlModel::at(const int &i) const | |||
|
|||
SqlModelPrivate::SqlModelPrivate(SqlModel *parent) | |||
{ | |||
|
|||
Q_UNUSED(parent); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trailing ; is not necessary here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The trailing ; is not necessary here.
ok
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey guys,
I do not agree with keeping this class in the current situation. I think the structure of this class needs to change. I have concerns about this, but I don't have enough time to do it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, btw. @HamedMasafi are you up to use the C++11 features? Like member initialisation in headers (what I would prefer because I think it results cleaner code)?
Hi @martonmiklos |
change private parameters initial sequence.