Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sqlmodel.cpp #80

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Update sqlmodel.cpp #80

wants to merge 2 commits into from

Conversation

soyoo
Copy link
Contributor

@soyoo soyoo commented Mar 17, 2020

change private parameters initial sequence.

change private parameters initial sequence.
src/sqlmodel.cpp Outdated
@@ -122,7 +122,7 @@ Row<Table> SqlModel::at(const int &i) const

SqlModelPrivate::SqlModelPrivate(SqlModel *parent)
{

Q_UNUSED(parent);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trailing ; is not necessary here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The trailing ; is not necessary here.

ok

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey guys,
I do not agree with keeping this class in the current situation. I think the structure of this class needs to change. I have concerns about this, but I don't have enough time to do it

@soyoo soyoo closed this Mar 29, 2020
@soyoo soyoo reopened this Mar 29, 2020
Copy link
Contributor

@martonmiklos martonmiklos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, btw. @HamedMasafi are you up to use the C++11 features? Like member initialisation in headers (what I would prefer because I think it results cleaner code)?

@HamedMasafi
Copy link
Owner

LGTM, btw. @HamedMasafi are you up to use the C++11 features? Like member initialisation in headers (what I would prefer because I think it results cleaner code)?

Hi @martonmiklos
Yes, in my opinion, c++11 can be considered as a base standard for the project

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants