Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vkd3d: Stagger submissions in single-queue scenarios. #2083

Merged
merged 1 commit into from
Aug 26, 2024
Merged

vkd3d: Stagger submissions in single-queue scenarios. #2083

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion libs/vkd3d/command.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18251,7 +18251,7 @@ static bool d3d12_command_queue_needs_staggered_submissions_locked(struct d3d12_
vkd3d_atomic_uint64_store_explicit(&command_queue->last_submission_time_ns,
current_time_ns, vkd3d_memory_order_relaxed);

/* Never stagger submissions for the highest-priority active queue. */
/* Do not stagger submissions for the highest-priority active queue. */
max_priority = command_queue->desc.Priority;

for (i = 0; i < command_queue->vkd3d_queue->command_queue_count; i++)
Expand All @@ -18261,7 +18261,16 @@ static bool d3d12_command_queue_needs_staggered_submissions_locked(struct d3d12_
queue_submit_time_ns = vkd3d_atomic_uint64_load_explicit(&q->last_submission_time_ns, vkd3d_memory_order_relaxed);

if (queue_submit_time_ns + VKD3D_QUEUE_INACTIVE_THRESHOLD_NS > current_time_ns)
{
max_priority = max(max_priority, q->desc.Priority);

/* Enable staggered submission logic if graphics and non-graphics
* queues are active at the same time. This should only happen on
* devices with one queue family, or when setting single_queue. */
if (q->desc.Type != command_queue->desc.Type &&
(q->desc.Type == D3D12_COMMAND_LIST_TYPE_DIRECT || command_queue->desc.Type == D3D12_COMMAND_LIST_TYPE_DIRECT))
return true;
}
}

if (command_queue->desc.Priority == max_priority)
Expand Down