Fence worker callback + work around MHW sparse bug #2333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Philip Rebohle <[email protected]>
Signed-off-by: Philip Rebohle <[email protected]>
Signed-off-by: Philip Rebohle <[email protected]>
Works around a Monster Hunter Wilds bug with DLSS FG enabled. Signed-off-by: Philip Rebohle <[email protected]>
Signed-off-by: Philip Rebohle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The callback refactor moves all the hardcoded stuff that we do in the fence worker to callbacks, and stores callback data within the
vkd3d_fence_wait_infostructure.For fence waits it doesn't look like there was any reason at all to keep the fence objects alive, so I removed that part.
Lastly, this adds some tracking to keep sparse resources alive through page table updates; otherwise, Monster Hunter Wilds screws up synchronization somewhere and will either crash or hang on Nvidia when starting the benchmark with DLSS FG enabled.