Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Retry session #193

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Retry session #193

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5854d62
Retry connection
jessedijkstra Dec 13, 2017
ae00fb2
Reduce retries to 3
jessedijkstra Dec 13, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions lib/hound/session.ex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,7 @@ defmodule Hound.Session do
desiredCapabilities: capabilities
}

# No retries for this request
make_req(:post, "session", params)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@HashNuke Do you remember why we did not have any retries for this request?

make_req(:post, "session", params, %{}, 3)
end

@doc "Make capabilities for session"
Expand Down