Support zksync #7
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexkeating
commented
Jun 20, 2024
src/MultiClaimsHatterFactory.sol
Outdated
|
|
||
| contract MultiClaimsHatterFactory { | ||
| // should the version be higher here | ||
| string public constant VERSION = "0.6.0"; |
alexkeating
commented
Jun 20, 2024
src/MultiClaimsHatterFactory.sol
Outdated
| // should the version be higher here | ||
| string public constant VERSION = "0.6.0"; | ||
|
|
||
| event HatsModuleFactory_ModuleDeployed( |
alexkeating
commented
Jun 20, 2024
src/MultiClaimsHatterFactory.sol
Outdated
| string public constant VERSION = "0.6.0"; | ||
|
|
||
| event HatsModuleFactory_ModuleDeployed( | ||
| address implementation, address instance, uint256 hatId, bytes otherImmutableArgs, bytes initData, uint256 saltNonce |
alexkeating
commented
Jun 20, 2024
test/MultiClaimsHatter.t.sol
Outdated
| vm.expectEmit(); | ||
| emit HatsClaimabilitySet(initialHats, initialClaimTypes); | ||
| // vm.expectEmit(); | ||
| // emit HatsClaimabilitySet(initialHats, initialClaimTypes); |
There was a problem hiding this comment.
Should this be commented out
alexkeating
commented
Jun 28, 2024
| vm.expectRevert("Initializable: contract is already initialized"); | ||
| instance.setUp(""); | ||
| } | ||
| // Returns nothing |
There was a problem hiding this comment.
Initialization should be added back
* Updated dependency to support-zksync HatsModule
alexkeating
commented
Jul 5, 2024
script/DeployMultiClaimsHatter.ts
Outdated
| const SALT_NONCE = 1; | ||
| const FACTORY_ADDRESS = "0x1e8C2a171e5c5D92d15F5363fd136CAf3bBf86E2" | ||
| // What does this need to be? | ||
| // const INIT_DATA = "0x000000000000000000000000000000000000000000000000000000000000004000000000000000000000000000000000000000000000000000000000000000c000000000000000000000000000000000000000000000000000000000000000030000000100010001000000000000000000000000000000000000000000000000000000010001000100010000000000000000000000000000000000000000000000000001000100010001000100000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000000003000000000000000000000000000000000000000000000000000000000000000100000000000000000000000000000000000000000000000000000000000000020000000000000000000000000000000000000000000000000000000000000001" |
There was a problem hiding this comment.
Build init data without claimable hat, setting overall configuration for the instance, and not making any individual hats setting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description