-
-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[tests] Compilation server vs defineModule/defineType #11159
[tests] Compilation server vs defineModule/defineType #11159
Conversation
7e9d5d7
to
2b23a94
Compare
2b23a94
to
cd944b7
Compare
... I think current failures might actually be false negatives. I managed to reproduce a few failures locally, and this is the debug data:
The prints that were not found were actually there, but some have been merged into a single "message"... |
Mac-specific JS failures? Huh... |
Nope it's not mac specific failures, can happen on linux too. |
OK, I got it into control Haxe server prints are passed as Fixed in #11459 |
4016f0d
to
9501f43
Compare
Works on 4.3.x too but requires #11153 to be added to 4.3_bugfix |
…#11159) * [tests] server tests - basic support for @:variant * [tests] add server test for compilation server safe type building * [tests] server tests - error handling for @:variant * [tests] add debug info * [tests] temp change of build params * [tests] add more debug data * [tests] better debug data on failures * [tests] reenable other server tests
Goal
defineModule
/defineType
Provided implementation
Feel free to suggest changes to the implementation I provided, as I plan to put in on the cookbook.
I did not manage to break it, but if you find a way please tell me and I'll update the tests and try to address the issue.
I also looked into implementing
CompilationServer.isAlive(t:Type):Bool
but it wasn't working as well as the custom implementation I'm using here in the end...Note: name mangling is very minimal there and won't be enough in some (many) cases; will add something about it in cookbook to tell people to use something that will generate truly unique names for their use case (any suggestion on a particular
haxe.macro.Type
name mangling implementation?)