-
-
Notifications
You must be signed in to change notification settings - Fork 657
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
OCaml 5.0 compatibility #11272
OCaml 5.0 compatibility #11272
Conversation
Would you rebase it on top of 4.3.2 such that I can use it as a patch for packaging? |
I can't until I have a new implementation for the memory-related features :/ |
I thought you've disabled the memory features temporily in this PR? |
d17f492
to
cd7da8e
Compare
I updated the lib we needed for memory features so that it works on both ocaml 4.08 and 5.0; I didn't want 4.3.x releases missing features that would break some editor features. I'm not sure what exactly you need. If this PR produces what you're after, I can backport it to 4.3_bugfix branch tomorrow morning. |
Great! Thanks a lot for the quick work.
Yes, that will do. I will than able to generate a patch to apply it on top of the 4.3.2 source. |
cd7da8e
to
0efe538
Compare
I also pushed to |
* OCaml 5 compatibility * [eval] Disable StdThread.kill which has been removed in ocaml 5 * [ci] Build and test with both ocaml 4 and 5 on linux
Makes the codebase compatible with both ocaml 4.08 and 5.0. CI now runs for both on linux.
I had to disable StdThread.kill on eval which was probably not even working in the first place. Will likely need to disable it more nicely (from std side?) and cleanup the commented out code.
Closes #11271