Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[diagnostics] do not define display for json rpc diagnostics #11746

Merged
merged 1 commit into from
Aug 7, 2024
Merged

[diagnostics] do not define display for json rpc diagnostics #11746

merged 1 commit into from
Aug 7, 2024

Conversation

kLabz
Copy link
Contributor

@kLabz kLabz commented Aug 7, 2024

Json RPC diagnostics, unlike legacy diagnostics:

  • do write to cache (and so will impact future compilations through server)
  • ... do define display, meaning things like if (Context.defined("display")) skipImportantButCostlyWork() will be impacted

@kLabz kLabz added the feature-ide IDE / Editor support label Aug 7, 2024
@kLabz kLabz added this to the 4.3 Hotfix milestone Aug 7, 2024
@kLabz kLabz merged commit 8bcaf33 into development Aug 7, 2024
98 checks passed
kLabz added a commit that referenced this pull request Aug 7, 2024
@kLabz
[diagnostics] do not define display for json rpc diagnostics (#11746)
458833c
@kLabz kLabz removed this from the 4.3 Hotfix milestone Aug 7, 2024
@skial skial mentioned this pull request Aug 7, 2024
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
feature-ide IDE / Editor support
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@kLabz