Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

handle HttpNodeJs request error #11777

Open
wants to merge 1 commit into
base: development
Choose a base branch
from
Open

handle HttpNodeJs request error #11777

wants to merge 1 commit into from

Conversation

josuigoa
Copy link

@josuigoa josuigoa commented Sep 19, 2024 •
edited
Loading

Without this change, the error thrown by the request must be handled with a generic

js.Node.process.on('uncaughtException', (e) -> trace(e));

I think is more convenient to handle the error with request.onError

@Simn
Copy link
Member

Simn commented Oct 15, 2024

I agree with this, but I don't know if it should add this "Http Request Error: " prefix...

@josuigoa
Copy link
Author

josuigoa commented Oct 15, 2024 •
edited
Loading

No problem, should I remove the prefix entirely and only throw the 'e'? Or do you have something else in mind?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@josuigoa @Simn