[hl] Respect hl-legacy32 for I64 arrays #11903
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobil4sk
force-pushed
the
fix/hl-legacy32
branch
from
b364785 to
651913f
Compare
|
I don't really have an idea of how hl32 is working (and how to test it properly), so I'm good as long as CI is green. |
It is None if hl-legacy32 is defined
tobil4sk
force-pushed
the
fix/hl-legacy32
branch
from
b16d6cd to
0f02947
Compare
|
Seems that the mac macro tests failed randomly, it should pass if the failed job is rerun... 😅 For testing, I just built a hello world sample with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since #11734, the
hl-legacy32define is not respected byArrayBytes<I64>.This avoids the issue, however, I'm not sure if other parts of genhl.ml should be changed too?
(Alternatively, maybe
hl-legacy32support should be removed along with 32 bit support in hashlink)