Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move all prebuild functionality into dune. #11966

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Move all prebuild functionality into dune. #11966

merged 1 commit into from
Feb 3, 2025
+48 −49

Conversation

Apprentice-Alchemist
Copy link
Contributor

This makes dune build work out of the box.
Passing ADD_REVISION, STATICLINK and LIB_PARAMS via make or environment variables should still work as expected, though LIB_PARAMS may need additional quoting.

@kLabz
Copy link
Contributor

kLabz commented Feb 3, 2025

Works for me 👍

@Simn Simn merged commit eaf9dc7 into HaxeFoundation:development Feb 3, 2025
58 checks passed
@Apprentice-Alchemist Apprentice-Alchemist deleted the more-dune branch February 3, 2025 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Apprentice-Alchemist @kLabz @Simn