Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the dataconfig changes after 194a712 #23

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 7 additions & 11 deletions zoology/experiments/examples/basic.py
Original file line number Diff line number Diff line change
@@ -1,19 +1,15 @@
from zoology.config import TrainConfig, ModelConfig, DataConfig, FunctionConfig, ModuleConfig

from zoology.config import TrainConfig, ModelConfig, DataConfig, ModuleConfig
from zoology.data.associative_recall import MQARConfig

factory_kwargs = {
"num_kv_pairs": 4,
}

config = TrainConfig(
data=DataConfig(
# cache_dir="/path/to/cache/dir" TODO: add this
vocab_size=256,
input_seq_len=64,
num_train_examples=10_000,
num_test_examples=1_000,
builder=FunctionConfig(
name="zoology.data.associative_recall.multiquery_ar",
kwargs={"num_kv_pairs": 4}
),

train_configs=[MQARConfig(num_examples=10_000, vocab_size=256, input_seq_len=64, **factory_kwargs)],
test_configs=[MQARConfig(num_examples=1_000, vocab_size=256, input_seq_len=64, **factory_kwargs)],
),
model=ModelConfig(
vocab_size=256,
Expand Down
20 changes: 7 additions & 13 deletions zoology/experiments/examples/basic_sweep.py
Original file line number Diff line number Diff line change
@@ -1,26 +1,20 @@
import numpy as np
from zoology.config import TrainConfig
from zoology.config import TrainConfig, ModelConfig, DataConfig, FunctionConfig, ModuleConfig

from zoology.config import TrainConfig, ModelConfig, DataConfig, FunctionConfig, ModuleConfig
from zoology.config import TrainConfig, ModelConfig, DataConfig, ModuleConfig
from zoology.data.associative_recall import MQARConfig


configs = []
factory_kwargs = {
"num_kv_pairs": 4,
}

for lr in np.logspace(-4, -2, 10):

config = TrainConfig(
data=DataConfig(
# cache_dir="/path/to/cache/dir" TODO: add a directory where data will be cached
vocab_size=256,
input_seq_len=64,
num_train_examples=10_000,
num_test_examples=1_000,
builder=FunctionConfig(
name="zoology.data.associative_recall.multiquery_ar",
kwargs={"num_kv_pairs": 4}
),

train_configs=[MQARConfig(num_examples=10_000, vocab_size=256, input_seq_len=64, **factory_kwargs)],
test_configs=[MQARConfig(num_examples=1_000, vocab_size=256, input_seq_len=64, **factory_kwargs)],
),
model=ModelConfig(
vocab_size=256,
Expand Down