fix: edge case for iOS, issue with mouse enter/leave events on adContainerDiv #1
+17
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Viktor286hearts
requested review from
opinxit,
christianbkoehler and
eunicekokor
Viktor286hearts
force-pushed
the
fix/mouseenter-mouseleave-handlers-on-iOS
branch
from
8308bf9 to
3a248b6
Compare
opinxit
pushed a commit
that referenced
this pull request
Oct 1, 2019
Ad play/pause control changes when adContainer is clicked.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a proposal for a fix to the issue described at googleads#808 [mouseenter/mouseleave handlers prevent SKIP AD button click in iOS]
The fix excludes iOS cases from adding
mouseenter&mouseleaveevents toadContainerDiv, since those events introduce issues with iOS mobile safaritouchbehavior.More info in the issue description googleads#808